Add a couple of code review guidelines#9516
Merged
bergundy merged 1 commit intotemporalio:mainfrom Mar 17, 2026
Merged
Conversation
stephanos
approved these changes
Mar 13, 2026
stpierre
pushed a commit
that referenced
this pull request
Mar 17, 2026
- Use `errors.AsType` instead of `errors.As` - Use `require.ErrorContains` instead of two separate assertions (`require.Error` + `require.Contains`)
Merged
temporal-cicd bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
- Use `errors.AsType` instead of `errors.As` - Use `require.ErrorContains` instead of two separate assertions (`require.Error` + `require.Contains`)
stephanos
pushed a commit
that referenced
this pull request
Mar 17, 2026
- Use `errors.AsType` instead of `errors.As` - Use `require.ErrorContains` instead of two separate assertions (`require.Error` + `require.Contains`)
stephanos
pushed a commit
that referenced
this pull request
Mar 18, 2026
- Use `errors.AsType` instead of `errors.As` - Use `require.ErrorContains` instead of two separate assertions (`require.Error` + `require.Contains`)
stephanos
pushed a commit
that referenced
this pull request
Mar 20, 2026
- Use `errors.AsType` instead of `errors.As` - Use `require.ErrorContains` instead of two separate assertions (`require.Error` + `require.Contains`)
birme
pushed a commit
to eyevinn-osaas/temporal
that referenced
this pull request
Mar 23, 2026
- Use `errors.AsType` instead of `errors.As` - Use `require.ErrorContains` instead of two separate assertions (`require.Error` + `require.Contains`)
stephanos
pushed a commit
that referenced
this pull request
Mar 23, 2026
- Use `errors.AsType` instead of `errors.As` - Use `require.ErrorContains` instead of two separate assertions (`require.Error` + `require.Contains`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errors.AsTypeinstead oferrors.Asrequire.ErrorContainsinstead of two separate assertions (require.Error+require.Contains)