Add checks for other tests using force replication#9541
Merged
michaely520 merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
spkane31
approved these changes
Mar 17, 2026
stephanos
pushed a commit
that referenced
this pull request
Mar 17, 2026
## What changed? Adding the visibility precondition check to the other tests that are utilizing force replication to wait for visibility to catch up. ## Why? flakiness go byebye? ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
stephanos
pushed a commit
that referenced
this pull request
Mar 18, 2026
## What changed? Adding the visibility precondition check to the other tests that are utilizing force replication to wait for visibility to catch up. ## Why? flakiness go byebye? ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
stephanos
pushed a commit
that referenced
this pull request
Mar 20, 2026
## What changed? Adding the visibility precondition check to the other tests that are utilizing force replication to wait for visibility to catch up. ## Why? flakiness go byebye? ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
birme
pushed a commit
to eyevinn-osaas/temporal
that referenced
this pull request
Mar 23, 2026
## What changed? Adding the visibility precondition check to the other tests that are utilizing force replication to wait for visibility to catch up. ## Why? flakiness go byebye? ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
stephanos
pushed a commit
that referenced
this pull request
Mar 23, 2026
## What changed? Adding the visibility precondition check to the other tests that are utilizing force replication to wait for visibility to catch up. ## Why? flakiness go byebye? ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adding the visibility precondition check to the other tests that are utilizing force replication to wait for visibility to catch up.
Why?
flakiness go byebye?
How did you test it?