Nexus Standalone: Feature flag#9567
Merged
stephanos merged 4 commits intofeature/nexus-standalonefrom Mar 19, 2026
Merged
Conversation
stephanos
changed the title
stephanos
force-pushed
the
stephanos/nexus-standalone-feature-flag
branch
from
fbebde9 to
aad2aa4
Compare
stephanos
force-pushed
the
stephanos/nexus-standalone-feature-flag
branch
from
aad2aa4 to
1404d9d
Compare
stephanos
commented
Mar 18, 2026
| if !h.config.Enabled(req.GetNamespace()) { | ||
| return nil, ErrStandaloneNexusOperationDisabled | ||
| } | ||
| return nil, serviceerror.NewUnimplemented("DeleteNexusOperationExecution not implemented") |
Contributor
Author
There was a problem hiding this comment.
^ fix after the feature branch was rebased on main
stephanos
commented
Mar 18, 2026
chasm/lib/nexusoperation/frontend.go
Outdated
| func (h *frontendHandler) StartNexusOperationExecution(context.Context, *workflowservice.StartNexusOperationExecutionRequest) (*workflowservice.StartNexusOperationExecutionResponse, error) { | ||
| // IsStandaloneNexusOperationEnabled checks if standalone Nexus operations are enabled for the given namespace. | ||
| func (h *frontendHandler) IsStandaloneNexusOperationEnabled(namespaceName string) bool { | ||
| return h.config.Enabled(namespaceName) |
Contributor
Author
There was a problem hiding this comment.
Should we also check ChasmEnabled here?
Member
There was a problem hiding this comment.
Yeah, we can't enable CHASM by default until OSS 1.32 unfortunately to support rollback to the previous minor. 1.31 is the first OSS version where CHASM would become stable.
bergundy
approved these changes
Mar 19, 2026
chasm/lib/nexusoperation/frontend.go
Outdated
| func (h *frontendHandler) StartNexusOperationExecution(context.Context, *workflowservice.StartNexusOperationExecutionRequest) (*workflowservice.StartNexusOperationExecutionResponse, error) { | ||
| // IsStandaloneNexusOperationEnabled checks if standalone Nexus operations are enabled for the given namespace. | ||
| func (h *frontendHandler) IsStandaloneNexusOperationEnabled(namespaceName string) bool { | ||
| return h.config.Enabled(namespaceName) |
Member
There was a problem hiding this comment.
Yeah, we can't enable CHASM by default until OSS 1.32 unfortunately to support rollback to the previous minor. 1.31 is the first OSS version where CHASM would become stable.
stephanos
added a commit
that referenced
this pull request
Apr 6, 2026
## What changed? Add Nexus Standalone feature flag. ## How did you test it? Tests will be added to respective API impl.
stephanos
added a commit
that referenced
this pull request
Apr 7, 2026
## What changed? Add Nexus Standalone feature flag. ## How did you test it? Tests will be added to respective API impl.
stephanos
added a commit
that referenced
this pull request
Apr 7, 2026
## What changed? Add Nexus Standalone feature flag. ## How did you test it? Tests will be added to respective API impl.
stephanos
added a commit
that referenced
this pull request
Apr 8, 2026
## What changed? Add Nexus Standalone feature flag. ## How did you test it? Tests will be added to respective API impl.
stephanos
added a commit
that referenced
this pull request
Apr 8, 2026
## What changed? Add Nexus Standalone feature flag. ## How did you test it? Tests will be added to respective API impl.
stephanos
added a commit
that referenced
this pull request
Apr 9, 2026
## What changed? Add Nexus Standalone feature flag. ## How did you test it? Tests will be added to respective API impl.
stephanos
added a commit
that referenced
this pull request
Apr 9, 2026
## What changed? Add Nexus Standalone feature flag. ## How did you test it? Tests will be added to respective API impl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add Nexus Standalone feature flag.
How did you test it?
Tests will be added to respective API impl.