Support file scheme for JWT key provider#9590
Open
simvlad wants to merge 1 commit intotemporalio:mainfrom
Open
Support file scheme for JWT key provider#9590simvlad wants to merge 1 commit intotemporalio:mainfrom
simvlad wants to merge 1 commit intotemporalio:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ee1d9968d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
simvlad
force-pushed
the
simvlad/local-jwt-key-provider
branch
from
9ee1d99 to
c14e43c
Compare
simvlad
force-pushed
the
simvlad/local-jwt-key-provider
branch
from
c14e43c to
bdbb92b
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add
file://URI support tojwtKeyProvider.keySourceURIs, so JWKS can be loaded directly from disk without running an HTTP server.Why?
Easier to test JWT key provider locally, when you don't need to spin up a sidecar HTTP server.
How did you test it?
Potential risks
Safe, as this is an additive change and http.Get would have failed on file:// schema with
unsupported protocol scheme "file".