Skip to content

Bump dependencies to address security CVEs for v1.30.2#9610

Merged
rkannan82 merged 4 commits intorelease/v1.30.xfrom
security/v1.30.2-dep-bumps
Mar 21, 2026
Merged

Bump dependencies to address security CVEs for v1.30.2#9610
rkannan82 merged 4 commits intorelease/v1.30.xfrom
security/v1.30.2-dep-bumps

Conversation

@rkannan82
Copy link
Copy Markdown
Contributor

Summary

Bumps dependencies flagged by Trivy scan to address CVEs in the v1.30.2 release image:

Risk assessment

  • grpc v1.72.2 → v1.79.3: Largest change. 7 minor version jump with ~30 transitive dependency upgrades (protobuf, x/net, x/crypto, envoy control plane, genproto, etc.). Builds cleanly. Note: this bump has not been done on main yet.
  • otel/sdk v1.34.0 → v1.40.0: Already landed on main via Bump go.opentelemetry.io/otel/sdk from 1.34.0 to 1.40.0 and fix tests #9442. Includes test fixes for testify v1.11.0 EventuallyWithT behavior change.
  • Go 1.25.7 → 1.25.8: Patch version, minimal risk.
  • zlib: Alpine package upgrade via apk upgrade --no-cache zlib in both server and admin-tools Dockerfiles.

Test plan

  • CI passes on this PR
  • After merge, wait for Build & Publish to produce new image
  • Re-run nightly validation with new image SHA
  • Re-run long-haul test
  • Re-run Trivy scan to confirm CVEs are resolved
  • Get security clearance from #team-eng-security-it

Made with Cursor

Addresses CVE-2026-24051 (HIGH) in go.opentelemetry.io/otel/sdk.
Cherry-picked from main (f7a3d63), dropped TestForceCAN_WithOverrideState
which depends on features not present on release/v1.30.x.

Made-with: Cursor
Addresses CVE-2026-33186 (CRITICAL) in google.golang.org/grpc.
Also bumps transitive dependencies: protobuf, x/net, x/crypto, x/oauth2,
envoy control plane, genproto, etc.

Made-with: Cursor
Addresses CVE-2026-25679 (HIGH) in net/url and includes security fixes
to html/template and os packages.

Made-with: Cursor
Adds explicit zlib upgrade to both server and admin-tools Dockerfiles
to pull in zlib 1.3.2-r0 from Alpine 3.23 repos, fixing the global
buffer overflow in the untgz utility.

Made-with: Cursor
@rkannan82 rkannan82 merged commit df877a8 into release/v1.30.x Mar 21, 2026
230 of 251 checks passed
rkannan82 added a commit that referenced this pull request Mar 21, 2026
## Summary

Bumps dependencies to address security CVEs on `main`:

- **CVE-2026-33186 (CRITICAL)**: `google.golang.org/grpc` v1.72.2 →
v1.79.3 — authorization bypass via missing leading `/` in `:path` header
- **CVE-2026-22184 (HIGH)**: Alpine `zlib` 1.3.1-r2 → 1.3.2-r0 — global
buffer overflow in `untgz` utility

Note: The other two CVEs from the v1.30.2 security review are already
addressed on `main`:
- otel/sdk v1.40.0 — already landed via #9442
- Go stdlib — `main` is on Go 1.26.0 (separate release series)

## Risk assessment

- **grpc v1.72.2 → v1.79.3**: 7 minor version jump with ~23 transitive
dependency upgrades. Builds cleanly. Same bump successfully applied to
`release/v1.30.x` in #9610.
- **zlib**: Alpine package upgrade via `apk upgrade --no-cache zlib` in
both server and admin-tools Dockerfiles.

## Test plan

- [ ] CI passes


Made with [Cursor](https://cursor.com)
birme pushed a commit to eyevinn-osaas/temporal that referenced this pull request Mar 23, 2026
…ralio#9611)

## Summary

Bumps dependencies to address security CVEs on `main`:

- **CVE-2026-33186 (CRITICAL)**: `google.golang.org/grpc` v1.72.2 →
v1.79.3 — authorization bypass via missing leading `/` in `:path` header
- **CVE-2026-22184 (HIGH)**: Alpine `zlib` 1.3.1-r2 → 1.3.2-r0 — global
buffer overflow in `untgz` utility

Note: The other two CVEs from the v1.30.2 security review are already
addressed on `main`:
- otel/sdk v1.40.0 — already landed via temporalio#9442
- Go stdlib — `main` is on Go 1.26.0 (separate release series)

## Risk assessment

- **grpc v1.72.2 → v1.79.3**: 7 minor version jump with ~23 transitive
dependency upgrades. Builds cleanly. Same bump successfully applied to
`release/v1.30.x` in temporalio#9610.
- **zlib**: Alpine package upgrade via `apk upgrade --no-cache zlib` in
both server and admin-tools Dockerfiles.

## Test plan

- [ ] CI passes


Made with [Cursor](https://cursor.com)
rkannan82 added a commit that referenced this pull request Mar 23, 2026
- google.golang.org/grpc v1.79.3 (CVE-2026-33186, CRITICAL)
- go.opentelemetry.io/otel/sdk v1.40.0 (CVE-2026-24051, HIGH)
- golang.org/x/oauth2 v0.34.0 (CVE-2025-22868, HIGH)
- golang.org/x/net, x/crypto, x/sys, x/sync, x/text, x/exp updated
- cel.dev/expr, go.uber.org/dig indirect dep updates

Cherry-picked from #9610 with conflict resolution:
- Kept temporal.io/api v1.53.0 and temporal.io/sdk v1.35.0 (1.29.x compat)
- Excluded pre-1.30 Dockerfile changes (docker-builds manages those)
- Test assertion correctness fixes from #9610 included

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82 added a commit that referenced this pull request Mar 23, 2026
…vior

Move release() calls outside EventuallyWithT and add explicit sleep so the
lock hold duration is measurable before the assertion runs. Required by the
testify v1.11.0 EventuallyWithT behavior change that shipped with otel/sdk
v1.40.0 upgrade.

Cherry-picked fix from #9610.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82 added a commit that referenced this pull request Mar 23, 2026
…vior

Move release() calls outside EventuallyWithT and add explicit sleep so the
lock hold duration is measurable before the assertion runs. Required by the
testify v1.11.0 EventuallyWithT behavior change that shipped with otel/sdk
v1.40.0 upgrade.

Cherry-picked fix from #9610.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82 added a commit that referenced this pull request Mar 24, 2026
## Summary

Security dependency bumps for v1.29.4.1 security-only patch release.

### CVEs addressed

| CVE | Severity | Fix |
|-----|----------|-----|
| CVE-2026-33186 | CRITICAL | grpc v1.79.3 |
| CVE-2026-24051 | HIGH | otel/sdk v1.40.0 |
| CVE-2025-22868 | HIGH | x/oauth2 v0.34.0 |
| CVE-2026-25679 | HIGH | Go 1.25.8 (go directive) |

Alpine CVE (CVE-2026-22184) handled in docker-builds repo.

### Changes

- Dep bumps: grpc, otel/sdk (+ related), x/oauth2, x/net, x/crypto,
x/sys, x/sync, x/text, x/exp, cel.dev/expr, uber/dig
- `cache_test.go`: fix `EventuallyWithT` for otel/sdk v1.40.0 + testify
v1.11.1 behavior change (move `release()` outside callback, add explicit
sleep)
- `caching_redirector_test.go`: wrap StaleTTL final assertion in
`EventuallyWithT` to avoid hang under testify v1.11.1
- `worker_deployment_test.go`: fix `verifyDescribeWorkerDeployment`
calls (missing `s.Require()` arg); add `proto.Equal` assertion during
delete verification

### Notes

- Dep bumps cherry-picked from #9610; test fixes adapted from #9442 and
#9569
- `temporal.io/api` (v1.53.0) and `temporal.io/sdk` (v1.35.0) kept at
1.29.x versions
- Pre-1.30 Dockerfiles excluded (managed in docker-builds repo)
- Test changes from #9442/#9569 that reference API fields not in v1.53.0
(LastCurrentTime, ForceCANVersionSignalArgs, GetPollerAutoscaling) are
not cherry-picked

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants