Nexus Standalone: Delete#9654
Merged
stephanos merged 23 commits intofeature/nexus-standalonefrom Apr 2, 2026
Merged
Conversation
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
3 times, most recently
from
a0b679b to
0909e5d
Compare
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
2 times, most recently
from
9658a07 to
ac37168
Compare
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
from
ac37168 to
44cdbf9
Compare
stephanos
changed the base branch from
feature/nexus-standalone
to
stephanos/nexus-standalone-cancel
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
2 times, most recently
from
dbc3b33 to
c37b856
Compare
bergundy
approved these changes
Mar 27, 2026
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Note the single comment before merging please.
| return serviceerror.NewInvalidArgumentf("operation_id exceeds length limit. Length=%d Limit=%d", | ||
| len(req.GetOperationId()), config.MaxIDLengthLimit()) | ||
| } | ||
| if len(req.GetRunId()) > config.MaxIDLengthLimit() { |
Member
There was a problem hiding this comment.
Didn't we change this to be validated as a UUID?
Contributor
Author
There was a problem hiding this comment.
This PR was created before that change; will backport 👍
Base automatically changed from
stephanos/nexus-standalone-cancel
to
feature/nexus-standalone
April 1, 2026 16:04
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
2 times, most recently
from
c229dd7 to
432d18e
Compare
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
2 times, most recently
from
d1ab106 to
caef9f9
Compare
stephanos/nexus-standalone-del chasm/lib/nexusoperation/gen/nexusoperationpb/v1/request_response.go-helpers.pb.go chasm/lib/nexusoperation/gen/nexusoperationpb/v1/request_response.pb.go
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
from
caef9f9 to
9c1a0a2
Compare
stephanos
added a commit
that referenced
this pull request
Apr 6, 2026
- [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s) Can't verify functional tests yet due to missing impl. normalize tests
stephanos
added a commit
that referenced
this pull request
Apr 6, 2026
- [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s) Can't verify functional tests yet due to missing impl. normalize tests
stephanos
added a commit
that referenced
this pull request
Apr 6, 2026
- [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s) Can't verify functional tests yet due to missing impl. normalize tests
stephanos
added a commit
that referenced
this pull request
Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 8, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 8, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 9, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 9, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 9, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 9, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stephanos
added a commit
that referenced
this pull request
Apr 9, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How did you test it?
Can't verify functional tests yet due to missing impl.