enable namespace mapper with fallbacks#9664
Merged
awln-temporal merged 3 commits intomainfrom Apr 9, 2026
Merged
Conversation
awln-temporal
force-pushed
the
namespace-mapper-enable
branch
4 times, most recently
from
4d1c2d8 to
2cd158d
Compare
awln-temporal
force-pushed
the
namespace-mapper-enable
branch
from
2cd158d to
5634fcb
Compare
rodrigozhou
requested changes
Apr 1, 2026
rodrigozhou
approved these changes
Apr 8, 2026
Comment on lines
34
to
41
| esCustomSearchAttributes = map[string]enumspb.IndexedValueType{ | ||
| "CustomIntField": enumspb.INDEXED_VALUE_TYPE_INT, | ||
| "CustomTextField": enumspb.INDEXED_VALUE_TYPE_TEXT, | ||
| "CustomKeywordField": enumspb.INDEXED_VALUE_TYPE_KEYWORD, | ||
| "CustomDatetimeField": enumspb.INDEXED_VALUE_TYPE_DATETIME, | ||
| "CustomDoubleField": enumspb.INDEXED_VALUE_TYPE_DOUBLE, | ||
| "CustomBoolField": enumspb.INDEXED_VALUE_TYPE_BOOL, | ||
| } |
Contributor
There was a problem hiding this comment.
Wondering if we could get rid of this. We can do in a another PR.
Contributor
Author
There was a problem hiding this comment.
can't get rid of this one, this is used in the operator handler to register search attributes, i can rename this though.
5 tasks
awln-temporal
added a commit
that referenced
this pull request
Apr 10, 2026
## What changed? Re-add noop mapper to fallback for visibility functional tests. ## Why? Fix visibility func test nil panic. #9664 introduced regressions, though somehow passed CI checks, where all visibility tests would panic upon checking the namespace mapper, which is a nil pointer. This change just points these to a noop mapper instance. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s).
stephanos
pushed a commit
that referenced
this pull request
Apr 13, 2026
## What changed? enable namespace mapper with fallbacks to the cluster metadata. ## Why? Allow backwards compatible rollout of search attribute mapper unification for ElasticSearch backed visibility stores. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [ ] added new functional test(s)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
enable namespace mapper with fallbacks to the cluster metadata.
Why?
Allow backwards compatible rollout of search attribute mapper unification for ElasticSearch backed visibility stores.
How did you test it?