Skip to content

Rename new Deployment Name and Build ID labels to be shorter#9723

Merged
carlydf merged 2 commits intomainfrom
cdf/rename-labels
Mar 27, 2026
Merged

Rename new Deployment Name and Build ID labels to be shorter#9723
carlydf merged 2 commits intomainfrom
cdf/rename-labels

Conversation

@carlydf
Copy link
Copy Markdown
Contributor

@carlydf carlydf commented Mar 27, 2026

What changed?

Change temporal_worker_deployment_name -> worker_deployment_name and temporal_worker_deployment_build_id -> worker_build_id.

Why?

Found out that External Obs can add the prefix later, as it does for other tags.
Also dropped _deployment_ from the build id tag because the build id has a stronger relation to the worker than the worker deployment, and this is easier to say and type.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

Zero risk. We added these labels last night. If we can patch this into OSS (or just merge to main and restart Long Haul) no one will ever see the tags we merged last night.


Note

Low Risk
Low risk change limited to renaming two metrics tag keys; the main impact is dashboards/alerts or external tooling expecting the old tag names.

Overview
Renames the metrics tag keys for worker deployment identifiers in common/metrics/tags.go, changing temporal_worker_deployment_name to worker_deployment_name and temporal_worker_deployment_build_id to worker_build_id for shorter labels.

Written by Cursor Bugbot for commit 979c85f. This will update automatically on new commits. Configure here.

@carlydf carlydf requested review from a team as code owners March 27, 2026 16:04
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

@carlydf carlydf requested a review from a team as a code owner March 27, 2026 16:07
@carlydf carlydf merged commit 64b4fbb into main Mar 27, 2026
84 of 95 checks passed
@carlydf carlydf deleted the cdf/rename-labels branch March 27, 2026 17:19
chaptersix pushed a commit to chaptersix/temporal that referenced this pull request Apr 2, 2026
…lio#9723)

## What changed?
Change `temporal_worker_deployment_name` -> `worker_deployment_name` and
`temporal_worker_deployment_build_id` -> `worker_build_id`.

## Why?
Found out that External Obs can add the prefix later, as it does for
other tags.
Also dropped `_deployment_` from the build id tag because the build id
has a stronger relation to the worker than the worker deployment, and
this is easier to say and type.

## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
Zero risk. We added these labels last night. If we can patch this into
OSS (or just merge to main and restart Long Haul) no one will ever see
the tags we merged last night.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk change limited to renaming two metrics tag keys; the main
impact is dashboards/alerts or external tooling expecting the old tag
names.
> 
> **Overview**
> Renames the metrics tag keys for worker deployment identifiers in
`common/metrics/tags.go`, changing `temporal_worker_deployment_name` to
`worker_deployment_name` and `temporal_worker_deployment_build_id` to
`worker_build_id` for shorter labels.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
979c85f. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
chaptersix pushed a commit to chaptersix/temporal that referenced this pull request Apr 2, 2026
…lio#9723)

## What changed?
Change `temporal_worker_deployment_name` -> `worker_deployment_name` and
`temporal_worker_deployment_build_id` -> `worker_build_id`.

## Why?
Found out that External Obs can add the prefix later, as it does for
other tags.
Also dropped `_deployment_` from the build id tag because the build id
has a stronger relation to the worker than the worker deployment, and
this is easier to say and type.

## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
Zero risk. We added these labels last night. If we can patch this into
OSS (or just merge to main and restart Long Haul) no one will ever see
the tags we merged last night.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk change limited to renaming two metrics tag keys; the main
impact is dashboards/alerts or external tooling expecting the old tag
names.
> 
> **Overview**
> Renames the metrics tag keys for worker deployment identifiers in
`common/metrics/tags.go`, changing `temporal_worker_deployment_name` to
`worker_deployment_name` and `temporal_worker_deployment_build_id` to
`worker_build_id` for shorter labels.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
979c85f. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
chaptersix pushed a commit that referenced this pull request Apr 2, 2026
## What changed?
Change `temporal_worker_deployment_name` -> `worker_deployment_name` and
`temporal_worker_deployment_build_id` -> `worker_build_id`.

## Why?
Found out that External Obs can add the prefix later, as it does for
other tags.
Also dropped `_deployment_` from the build id tag because the build id
has a stronger relation to the worker than the worker deployment, and
this is easier to say and type.

## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
Zero risk. We added these labels last night. If we can patch this into
OSS (or just merge to main and restart Long Haul) no one will ever see
the tags we merged last night.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk change limited to renaming two metrics tag keys; the main
impact is dashboards/alerts or external tooling expecting the old tag
names.
> 
> **Overview**
> Renames the metrics tag keys for worker deployment identifiers in
`common/metrics/tags.go`, changing `temporal_worker_deployment_name` to
`worker_deployment_name` and `temporal_worker_deployment_build_id` to
`worker_build_id` for shorter labels.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
979c85f. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
chaptersix pushed a commit to chaptersix/temporal that referenced this pull request Apr 2, 2026
…lio#9723)

## What changed?
Change `temporal_worker_deployment_name` -> `worker_deployment_name` and
`temporal_worker_deployment_build_id` -> `worker_build_id`.

## Why?
Found out that External Obs can add the prefix later, as it does for
other tags.
Also dropped `_deployment_` from the build id tag because the build id
has a stronger relation to the worker than the worker deployment, and
this is easier to say and type.

## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
Zero risk. We added these labels last night. If we can patch this into
OSS (or just merge to main and restart Long Haul) no one will ever see
the tags we merged last night.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk change limited to renaming two metrics tag keys; the main
impact is dashboards/alerts or external tooling expecting the old tag
names.
> 
> **Overview**
> Renames the metrics tag keys for worker deployment identifiers in
`common/metrics/tags.go`, changing `temporal_worker_deployment_name` to
`worker_deployment_name` and `temporal_worker_deployment_build_id` to
`worker_build_id` for shorter labels.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
979c85f. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants