Rename new Deployment Name and Build ID labels to be shorter#9723
Merged
Rename new Deployment Name and Build ID labels to be shorter#9723
Conversation
Shivs11
approved these changes
Mar 27, 2026
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
…lio#9723) ## What changed? Change `temporal_worker_deployment_name` -> `worker_deployment_name` and `temporal_worker_deployment_build_id` -> `worker_build_id`. ## Why? Found out that External Obs can add the prefix later, as it does for other tags. Also dropped `_deployment_` from the build id tag because the build id has a stronger relation to the worker than the worker deployment, and this is easier to say and type. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Zero risk. We added these labels last night. If we can patch this into OSS (or just merge to main and restart Long Haul) no one will ever see the tags we merged last night. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk change limited to renaming two metrics tag keys; the main impact is dashboards/alerts or external tooling expecting the old tag names. > > **Overview** > Renames the metrics tag keys for worker deployment identifiers in `common/metrics/tags.go`, changing `temporal_worker_deployment_name` to `worker_deployment_name` and `temporal_worker_deployment_build_id` to `worker_build_id` for shorter labels. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 979c85f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
…lio#9723) ## What changed? Change `temporal_worker_deployment_name` -> `worker_deployment_name` and `temporal_worker_deployment_build_id` -> `worker_build_id`. ## Why? Found out that External Obs can add the prefix later, as it does for other tags. Also dropped `_deployment_` from the build id tag because the build id has a stronger relation to the worker than the worker deployment, and this is easier to say and type. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Zero risk. We added these labels last night. If we can patch this into OSS (or just merge to main and restart Long Haul) no one will ever see the tags we merged last night. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk change limited to renaming two metrics tag keys; the main impact is dashboards/alerts or external tooling expecting the old tag names. > > **Overview** > Renames the metrics tag keys for worker deployment identifiers in `common/metrics/tags.go`, changing `temporal_worker_deployment_name` to `worker_deployment_name` and `temporal_worker_deployment_build_id` to `worker_build_id` for shorter labels. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 979c85f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
chaptersix
pushed a commit
that referenced
this pull request
Apr 2, 2026
## What changed? Change `temporal_worker_deployment_name` -> `worker_deployment_name` and `temporal_worker_deployment_build_id` -> `worker_build_id`. ## Why? Found out that External Obs can add the prefix later, as it does for other tags. Also dropped `_deployment_` from the build id tag because the build id has a stronger relation to the worker than the worker deployment, and this is easier to say and type. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Zero risk. We added these labels last night. If we can patch this into OSS (or just merge to main and restart Long Haul) no one will ever see the tags we merged last night. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk change limited to renaming two metrics tag keys; the main impact is dashboards/alerts or external tooling expecting the old tag names. > > **Overview** > Renames the metrics tag keys for worker deployment identifiers in `common/metrics/tags.go`, changing `temporal_worker_deployment_name` to `worker_deployment_name` and `temporal_worker_deployment_build_id` to `worker_build_id` for shorter labels. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 979c85f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
…lio#9723) ## What changed? Change `temporal_worker_deployment_name` -> `worker_deployment_name` and `temporal_worker_deployment_build_id` -> `worker_build_id`. ## Why? Found out that External Obs can add the prefix later, as it does for other tags. Also dropped `_deployment_` from the build id tag because the build id has a stronger relation to the worker than the worker deployment, and this is easier to say and type. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Zero risk. We added these labels last night. If we can patch this into OSS (or just merge to main and restart Long Haul) no one will ever see the tags we merged last night. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk change limited to renaming two metrics tag keys; the main impact is dashboards/alerts or external tooling expecting the old tag names. > > **Overview** > Renames the metrics tag keys for worker deployment identifiers in `common/metrics/tags.go`, changing `temporal_worker_deployment_name` to `worker_deployment_name` and `temporal_worker_deployment_build_id` to `worker_build_id` for shorter labels. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 979c85f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed?
Change
temporal_worker_deployment_name->worker_deployment_nameandtemporal_worker_deployment_build_id->worker_build_id.Why?
Found out that External Obs can add the prefix later, as it does for other tags.
Also dropped
_deployment_from the build id tag because the build id has a stronger relation to the worker than the worker deployment, and this is easier to say and type.How did you test it?
Potential risks
Zero risk. We added these labels last night. If we can patch this into OSS (or just merge to main and restart Long Haul) no one will ever see the tags we merged last night.
Note
Low Risk
Low risk change limited to renaming two metrics tag keys; the main impact is dashboards/alerts or external tooling expecting the old tag names.
Overview
Renames the metrics tag keys for worker deployment identifiers in
common/metrics/tags.go, changingtemporal_worker_deployment_nametoworker_deployment_nameandtemporal_worker_deployment_build_idtoworker_build_idfor shorter labels.Written by Cursor Bugbot for commit 979c85f. This will update automatically on new commits. Configure here.