Upgrade Go SDK version to 1.41.1#9753
Merged
bergundy merged 3 commits intotemporalio:mainfrom Apr 1, 2026
Merged
Conversation
long-nt-tran
commented
Mar 31, 2026
| github.com/maruel/panicparse/v2 v2.4.0 | ||
| github.com/mitchellh/mapstructure v1.5.0 | ||
| github.com/nexus-rpc/sdk-go v0.5.2-0.20260211051645-26b0b4c584e5 | ||
| github.com/nexus-rpc/sdk-go v0.6.0 |
Contributor
Author
There was a problem hiding this comment.
v.0.6.0 is the exact same commit head as 5.2-0.20260211051645-26b0b4c584e5, both point at nexus-rpc/sdk-go@26b0b4c
long-nt-tran
force-pushed
the
go-sdk-upgrade
branch
from
89bc564 to
d9a5a5f
Compare
bergundy
approved these changes
Apr 1, 2026
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
## What changed? 1. Updated Go SDK to latest version per https://pkg.go.dev/go.temporal.io/sdk?tab=versions, latest I see today is `v1.41.1` from Mar 17 2026 2. Ran `go mod tidy` 3. Some tests were failing due to SDK interface changing, ran `cd common/testing/mocksdk && go generate` -- generated changes in `common/testing/mocksdk/client_mock.go` 4. Fixed Nexus test suite due to breaking changes and deprecated APIs in new SDK -- changes in `tests/nexus_workflow_test.go` ## Why? To use the latest version of our SDK and keeping tests up-to-date. ## How did you test it? - [x] built - [x] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
## What changed? 1. Updated Go SDK to latest version per https://pkg.go.dev/go.temporal.io/sdk?tab=versions, latest I see today is `v1.41.1` from Mar 17 2026 2. Ran `go mod tidy` 3. Some tests were failing due to SDK interface changing, ran `cd common/testing/mocksdk && go generate` -- generated changes in `common/testing/mocksdk/client_mock.go` 4. Fixed Nexus test suite due to breaking changes and deprecated APIs in new SDK -- changes in `tests/nexus_workflow_test.go` ## Why? To use the latest version of our SDK and keeping tests up-to-date. ## How did you test it? - [x] built - [x] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
chaptersix
pushed a commit
that referenced
this pull request
Apr 2, 2026
## What changed? 1. Updated Go SDK to latest version per https://pkg.go.dev/go.temporal.io/sdk?tab=versions, latest I see today is `v1.41.1` from Mar 17 2026 2. Ran `go mod tidy` 3. Some tests were failing due to SDK interface changing, ran `cd common/testing/mocksdk && go generate` -- generated changes in `common/testing/mocksdk/client_mock.go` 4. Fixed Nexus test suite due to breaking changes and deprecated APIs in new SDK -- changes in `tests/nexus_workflow_test.go` ## Why? To use the latest version of our SDK and keeping tests up-to-date. ## How did you test it? - [x] built - [x] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
## What changed? 1. Updated Go SDK to latest version per https://pkg.go.dev/go.temporal.io/sdk?tab=versions, latest I see today is `v1.41.1` from Mar 17 2026 2. Ran `go mod tidy` 3. Some tests were failing due to SDK interface changing, ran `cd common/testing/mocksdk && go generate` -- generated changes in `common/testing/mocksdk/client_mock.go` 4. Fixed Nexus test suite due to breaking changes and deprecated APIs in new SDK -- changes in `tests/nexus_workflow_test.go` ## Why? To use the latest version of our SDK and keeping tests up-to-date. ## How did you test it? - [x] built - [x] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
v1.41.1from Mar 17 2026go mod tidycd common/testing/mocksdk && go generate-- generated changes incommon/testing/mocksdk/client_mock.gotests/nexus_workflow_test.goWhy?
To use the latest version of our SDK and keeping tests up-to-date.
How did you test it?