[Nexus] Minor fixes - Added destination queue and schedule cancellati…#9790
Merged
bergundy merged 1 commit intonexus/hsm-to-chasm-migrationfrom Apr 6, 2026
Merged
[Nexus] Minor fixes - Added destination queue and schedule cancellati…#9790bergundy merged 1 commit intonexus/hsm-to-chasm-migrationfrom
bergundy merged 1 commit intonexus/hsm-to-chasm-migrationfrom
Conversation
gow
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
48c21b2 to
5c6bbd9
Compare
…on in TransitionStarted
bergundy
approved these changes
Apr 6, 2026
bergundy
pushed a commit
to bergundy/temporal
that referenced
this pull request
Apr 7, 2026
temporalio#9790) ## What changed? Minor fixes. ## Why? These were missing or misplaced previously. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes task routing and cancellation scheduling in the Nexus operation state machine, which can affect execution flow and delivery to outbound queues. While localized, incorrect destinations or transition sequencing could cause stuck or misrouted operations. > > **Overview** > Ensures Nexus invocation tasks are routed to the correct outbound queue by setting `TaskAttributes.Destination` to the operation endpoint when scheduling and when rescheduling after backoff. > > Moves the "cancellation already requested" handling from the workflow `Started` event handler into `TransitionStarted`, so pending cancellations are automatically scheduled as soon as an operation token becomes available. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4eddec6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
bergundy
pushed a commit
to bergundy/temporal
that referenced
this pull request
Apr 7, 2026
temporalio#9790) ## What changed? Minor fixes. ## Why? These were missing or misplaced previously. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes task routing and cancellation scheduling in the Nexus operation state machine, which can affect execution flow and delivery to outbound queues. While localized, incorrect destinations or transition sequencing could cause stuck or misrouted operations. > > **Overview** > Ensures Nexus invocation tasks are routed to the correct outbound queue by setting `TaskAttributes.Destination` to the operation endpoint when scheduling and when rescheduling after backoff. > > Moves the "cancellation already requested" handling from the workflow `Started` event handler into `TransitionStarted`, so pending cancellations are automatically scheduled as soon as an operation token becomes available. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4eddec6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
bergundy
pushed a commit
that referenced
this pull request
Apr 8, 2026
#9790) ## What changed? Minor fixes. ## Why? These were missing or misplaced previously. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes task routing and cancellation scheduling in the Nexus operation state machine, which can affect execution flow and delivery to outbound queues. While localized, incorrect destinations or transition sequencing could cause stuck or misrouted operations. > > **Overview** > Ensures Nexus invocation tasks are routed to the correct outbound queue by setting `TaskAttributes.Destination` to the operation endpoint when scheduling and when rescheduling after backoff. > > Moves the "cancellation already requested" handling from the workflow `Started` event handler into `TransitionStarted`, so pending cancellations are automatically scheduled as soon as an operation token becomes available. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4eddec6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
bergundy
pushed a commit
that referenced
this pull request
Apr 9, 2026
#9790) ## What changed? Minor fixes. ## Why? These were missing or misplaced previously. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes task routing and cancellation scheduling in the Nexus operation state machine, which can affect execution flow and delivery to outbound queues. While localized, incorrect destinations or transition sequencing could cause stuck or misrouted operations. > > **Overview** > Ensures Nexus invocation tasks are routed to the correct outbound queue by setting `TaskAttributes.Destination` to the operation endpoint when scheduling and when rescheduling after backoff. > > Moves the "cancellation already requested" handling from the workflow `Started` event handler into `TransitionStarted`, so pending cancellations are automatically scheduled as soon as an operation token becomes available. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4eddec6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
bergundy
pushed a commit
that referenced
this pull request
Apr 9, 2026
#9790) ## What changed? Minor fixes. ## Why? These were missing or misplaced previously. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes task routing and cancellation scheduling in the Nexus operation state machine, which can affect execution flow and delivery to outbound queues. While localized, incorrect destinations or transition sequencing could cause stuck or misrouted operations. > > **Overview** > Ensures Nexus invocation tasks are routed to the correct outbound queue by setting `TaskAttributes.Destination` to the operation endpoint when scheduling and when rescheduling after backoff. > > Moves the "cancellation already requested" handling from the workflow `Started` event handler into `TransitionStarted`, so pending cancellations are automatically scheduled as soon as an operation token becomes available. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4eddec6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Minor fixes.
Why?
These were missing or misplaced previously.
How did you test it?
Note
Medium Risk
Changes task routing and cancellation scheduling in the Nexus operation state machine, which can affect execution flow and delivery to outbound queues. While localized, incorrect destinations or transition sequencing could cause stuck or misrouted operations.
Overview
Ensures Nexus invocation tasks are routed to the correct outbound queue by setting
TaskAttributes.Destinationto the operation endpoint when scheduling and when rescheduling after backoff.Moves the "cancellation already requested" handling from the workflow
Startedevent handler intoTransitionStarted, so pending cancellations are automatically scheduled as soon as an operation token becomes available.Written by Cursor Bugbot for commit 4eddec6. This will update automatically on new commits. Configure here.