Reset retention timer when schedule is unpaused#9862
Open
gurudatta-patil wants to merge 10 commits intotemporalio:mainfrom
Open
Reset retention timer when schedule is unpaused#9862gurudatta-patil wants to merge 10 commits intotemporalio:mainfrom
gurudatta-patil wants to merge 10 commits intotemporalio:mainfrom
Conversation
|
|
chaptersix
reviewed
Apr 8, 2026
chaptersix
reviewed
Apr 8, 2026
Contributor
|
Thank you for you contribution! Could update the |
Co-authored-by: Alex Stanfield <13949480+chaptersix@users.noreply.github.com>
Co-authored-by: Alex Stanfield <13949480+chaptersix@users.noreply.github.com>
Author
|
Updated the chasm/lib/scheduler path |
chaptersix
reviewed
Apr 13, 2026
chaptersix
reviewed
Apr 13, 2026
| // trigger immediately timestamp is added to the PatchRequest | ||
| TriggerImmediatelyTimestamp = 12 | ||
| // reset retention timer when a paused schedule is unpaused | ||
| ResetRetentionOnUnpause = 13 |
Contributor
There was a problem hiding this comment.
// Versions of workflow logic. When introducing a new version, consider generating a new
// history for TestReplays using generate_history.sh.
please do this
Author
There was a problem hiding this comment.
Uploaded the replay files of the history. Should I keep the default name or change the name. Unfamiliar with naming convention
Contributor
|
run |
Co-authored-by: Alex Stanfield <13949480+chaptersix@users.noreply.github.com>
Contributor
|
Everything else LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed schedule retention on unpause.
If a schedule stayed paused longer than retention, unpausing could close the scheduler workflow right away.
Now unpause resets the retention timer so retention starts from unpause time.
Also added a regression unit test for this case.
Why?
Paused time should not cause the schedule to age out immediately after unpause.
This matches expected schedule behavior.
How did you test it?
Ran the test before change and after change. Since minor change, built and created a unit test
Potential risks
Small behavior change around retention timing after unpause.
Fixes #9752