Nexus chasm invocation task unit tests#9880
Merged
bergundy merged 7 commits intotemporalio:nexus/hsm-to-chasm-migrationfrom Apr 10, 2026
Merged
Conversation
bergundy
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
7fbdb9f to
5be312b
Compare
bergundy
force-pushed
the
nexus-chasm-invocation-task-unit-tests
branch
from
344dd29 to
7e84525
Compare
stephanos
force-pushed
the
nexus/hsm-to-chasm-migration
branch
2 times, most recently
from
978ec33 to
12007cf
Compare
bergundy
force-pushed
the
nexus-chasm-invocation-task-unit-tests
branch
from
7e84525 to
55fefd3
Compare
bergundy
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
12007cf to
6ae06cc
Compare
bergundy
force-pushed
the
nexus-chasm-invocation-task-unit-tests
branch
2 times, most recently
from
f67e908 to
e5a6e08
Compare
bergundy
force-pushed
the
nexus/hsm-to-chasm-migration
branch
from
2138a0e to
3206e99
Compare
bergundy
force-pushed
the
nexus-chasm-invocation-task-unit-tests
branch
from
e5a6e08 to
9a70a1e
Compare
bergundy
force-pushed
the
nexus-chasm-invocation-task-unit-tests
branch
from
9a70a1e to
a606551
Compare
stephanos
approved these changes
Apr 10, 2026
| expectedMetricOutcome: "invalid-operation-token", | ||
| checkOutcome: func(t *testing.T, op *Operation, err error) { | ||
| require.NoError(t, err) | ||
| require.Equal(t, nexusoperationpb.OPERATION_STATUS_FAILED, op.Status) |
Contributor
There was a problem hiding this comment.
Should we assert that the error is non-retryable?
| schedToStartTimeout time.Duration | ||
| destinationDown bool | ||
| endpointNotFound bool | ||
| noUpdateComponent bool // Set to true when the handler returns early without calling UpdateComponent. |
Contributor
There was a problem hiding this comment.
seems like this is never true?
| require.NotNil(t, failure.Cause) | ||
| require.Equal(t, "cause", failure.Cause.Message) | ||
| require.NotNil(t, failure.Cause.GetApplicationFailureInfo()) | ||
| require.Equal(t, "NexusFailure", failure.Cause.GetApplicationFailureInfo().GetType()) |
Contributor
There was a problem hiding this comment.
non-blocking: would a single equal check on the full failure be easier to read (and write)? it's nice because it's exhaustive. It doesn't always work but it seems here it would.
| { | ||
| name: "async start", | ||
| requestTimeout: time.Hour, | ||
| checkStartOperationOptions: func(t *testing.T, options nexus.StartOperationOptions) { |
Contributor
There was a problem hiding this comment.
non-blocking: since this is the only use of this, could we fold these checks into onStartOperation and drop this field? I recognize that onStartOperation doesn't have testing.T, that could probably be added and still satisfy the nexustest AFAICT.
| schedToCloseTimeout time.Duration | ||
| startToCloseTimeout time.Duration | ||
| schedToStartTimeout time.Duration | ||
| destinationDown bool |
Contributor
There was a problem hiding this comment.
I see it being set to true but not used?
| onStartOperation func(ctx context.Context, service, operation string, input *nexus.LazyValue, options nexus.StartOperationOptions) (nexus.HandlerStartOperationResult[any], error) | ||
| expectedMetricOutcome string | ||
| checkOutcome func(t *testing.T, op *Operation, err error) | ||
| requestTimeout time.Duration |
Contributor
There was a problem hiding this comment.
why always set this one but not the other timeouts? Could use cmp.Or(tc.requestTimeout, time.Hour)
|
|
||
| var metricsHandler metrics.Handler | ||
| if tc.expectedMetricOutcome != "" { | ||
| mockMetrics := metrics.NewMockHandler(ctrl) |
Contributor
There was a problem hiding this comment.
Could this be metricstest.NewCaptureHandler() instead? Might be slightly simpler/shorter.
bergundy
merged commit d459b8a
into
temporalio:nexus/hsm-to-chasm-migration
45 checks passed
bergundy
added a commit
that referenced
this pull request
Apr 10, 2026
bergundy
added a commit
that referenced
this pull request
Apr 10, 2026
## What changed? Port the invocation executor tests from `components/nexusoperations/executor_tests.go` to CHASM. ## Why? Test coverage was missing previously.
bergundy
added a commit
that referenced
this pull request
Apr 10, 2026
stephanos
pushed a commit
that referenced
this pull request
Apr 13, 2026
Port the invocation executor tests from `components/nexusoperations/executor_tests.go` to CHASM. Test coverage was missing previously.
stephanos
pushed a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Port the invocation executor tests from
components/nexusoperations/executor_tests.goto CHASM.Why?
Test coverage was missing previously.