Skip to content

Add CORS configuration#69

Merged
feedmeapples merged 1 commit intomainfrom
cors
Oct 27, 2021
Merged

Add CORS configuration#69
feedmeapples merged 1 commit intomainfrom
cors

Conversation

@feedmeapples
Copy link
Copy Markdown
Contributor

@feedmeapples feedmeapples commented Oct 27, 2021

What was changed

Adds CORS configuration:

dockerize variable TEMPORAL_CORS_ORIGINS (or directly through the config file)

Why?

  • Allows to set up other CORS origins instead of hardcoded localhost:3000

Checklist

  1. Closes

  2. How was this tested:

docker run --network host -e TEMPORAL_CORS_ORIGINS=http://localhost:3000 temporaliotest/ui

  1. Any docs updates needed?

Updated docker README

@feedmeapples feedmeapples force-pushed the cors branch 2 times, most recently from 174d3a3 to 398be05 Compare October 27, 2021 21:58
Copy link
Copy Markdown
Contributor

@stevekinney stevekinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. This is way better than what we had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants