Svelte 4 and SvelteKit 2 Upgrade #1868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
Alex-Tideman
requested review from
a team,
Alex-Tideman,
rossedfort and
stevekinney
as code owners
laurakwhit
force-pushed
the
svelte-4-sveltekit-2
branch
from
e5f8e85 to
27f239f
Compare
Alex-Tideman
approved these changes
Feb 26, 2024
* first pass at new dark mode for... input, menu, select, and combobox * clean up some styles * fix checkbox * fix snaps, remove commented out style * fix some button stuff I broke * fix checkbox * clean up hover borders on menu button * fix tests/types * return empty string label if no selected option and no placeholder
…s is the final time and I won't make this mistake again after merging fixed the snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?