Fix(query): add delimiter to the query keyword#2015
Closed
alexseedkou wants to merge 2 commits intotemporalio:mainfrom
Closed
Fix(query): add delimiter to the query keyword#2015alexseedkou wants to merge 2 commits intotemporalio:mainfrom
alexseedkou wants to merge 2 commits intotemporalio:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
alexseedkou
changed the title
alexseedkou
force-pushed
the
fix-hyphen-attribute
branch
from
ea153db to
fc6d472
Compare
tdeebswihart
pushed a commit
to temporalio/temporal
that referenced
this pull request
May 15, 2024
## What changed? Add a test in the server to test the behavior when an attribute includes a hyphen character. This is a support PR for this [PR](temporalio/ui#2015) in UI ## Why? Please refer the details in the [PR](temporalio/ui#2015) in UI and the open [issue](#5557) ## How did you test it? ## Potential risks ## Documentation ## Is hotfix candidate?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
When send out a query of custom search attribute through the options on UI, the server will return back an error if the custom search attribute include hyphen (
-), this is because hyphen is a reserved character for SQL, to send the query including such characters need to introduce delimiter backtik`to escape.This will address the open issue here with the minimum change only on UI.
Here is another PR for adding tests in server.
Screenshots (if applicable) 📸
N/A
Design Considerations 🎨
Testing 🧪
Test it though a manual test. Will open another PR in server to include the test on the attribute name with hyphen in server.
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?