Skip to content

Revert #2709 due to CORS Issues#2772

Merged
rossnelson merged 1 commit intomainfrom
revert-2709-cors-issues
Jun 16, 2025
Merged

Revert #2709 due to CORS Issues#2772
rossnelson merged 1 commit intomainfrom
revert-2709-cors-issues

Conversation

@rossnelson
Copy link
Copy Markdown
Collaborator

Description & motivation 💭

/namespaces/{name}/workflows:1 Access to fetch at
'https://{url}/api/v1/namespaces/{namespace}/workflow-count?query=GROUP+BY+ExecutionStatus'
from origin 'https://{host}' has been blocked by CORS policy:
Response to preflight request doesn't pass access control check: The value of
the 'Access-Control-Allow-Origin' header in the response must not be the
wildcard '*' when the request's credentials mode is 'include'.

@rossnelson rossnelson requested a review from a team as a code owner June 16, 2025 21:41
@rossnelson rossnelson requested review from GiantRobots and removed request for a team June 16, 2025 21:41
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 9:41pm

@Alex-Tideman Alex-Tideman self-requested a review June 16, 2025 22:32
@rossnelson rossnelson merged commit 7484845 into main Jun 16, 2025
16 checks passed
@rossnelson rossnelson deleted the revert-2709-cors-issues branch June 16, 2025 23:06
Alex-Tideman pushed a commit that referenced this pull request Jun 17, 2025
Alex-Tideman added a commit that referenced this pull request Jun 25, 2025
* Add function to determine billableAction count

* Make the event history table better

* Add date to pending activity

* Add line-dot visualization back

* Remove borders, more table stuff

* Event Card

* Table changes

* WIP: icon placeholder and isCloud check

* Add dollar-invoice icon

* Show row details on Timeline to make them consistent

* Change grid if no payloads

* Fix timestamp and copyable button

* Fix type, comment out visibility store

* Use h-9 for the table header cell height to prevent shift on bulk actions

* Make title text bigger

* Update Card styles, add event links

* Include workflow rejected action

* Flip visibility to test

* Clean up cards

* Hide redudent fields

* Pending Activities fixes

* Update signal count on id

* UI improvements

* Add PendingNexusOperationCard

* Add check for WorkflowTaskFailedEvent due to reset and update billable actions accordingly

* Refactor to add shouldNotAddBillableAction check instead of resetBillableActionsBeforeEvent

* Fix formatDate to account for already formated date strings

* Use findLast for isWorkflowTaskFailedEventDueToReset

* Reset isCloud

* Event row UI improvements

* More UI fixes

* Remove borders on tables

* Remove nested css for ui-server (#2767)

* Deployment Versioning Updates (#2764)

* Svelte5 updates, cleanup. Need new API to convert deployment stuff

* Update deploys SAs to be filter/copyable, add Build Ids everywhere. Add new types

* Fix columns and headers to not have status as column

* Fix table widths, link to task queue show since current/ramping

* Remove console.log, add unit tests for version

* Set width and text-right on link column

* Add latest deployment build id and svelte5

* Use correct translation for ramping version

* Remove comment

* Update column to Actions and update link label

* Show __unversioned__, check if latestId is currentId

* Move back to Pre-Release tag

* Create Version Bump PR as Draft (#2769)

Some of the required checks dont run when its generated by github actions. The
always draft trick worked in cloud so lets try that in ui as well. This also
sets the author and committer to the user who created the PR.

* chore: bump version to 2.38.0 (#2770)

Auto-generated version bump from 2.37.2 to 2.38.0

Bump type: minor

Changes included:\nManual version bump

Co-authored-by: Alex-Tideman <7967403+Alex-Tideman@users.noreply.github.com>

* Revert #2709 due to CORS Issues (#2772)

* chore: bump version to 2.38.1 (#2773)

Auto-generated version bump from 2.38.0 to 2.38.1

Bump type: patch

Changes included:\nManual version bump

Co-authored-by: Alex-Tideman <7967403+Alex-Tideman@users.noreply.github.com>

* Make w-1/2 for event card split, fix summary field alignment

* Fix empty row colspan

* Update billing logic, remove dollar-invoice icon

* Check for version change SA

* Update event card spacing

* Update billing logic for schedules, add comments, more event card css

* Fix logic

* Better optional chaining

* Schedule count to 3, remove external signal

* Update to Billable Actions label

* More card spacing updates

* Remove Workers/Versioning tab on task queue page (#2783)

---------

Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
Co-authored-by: Ross Nelson <ross.nelson@temporal.io>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hferentschik pushed a commit to DataDog/temporalio-ui that referenced this pull request Mar 12, 2026
hferentschik pushed a commit to DataDog/temporalio-ui that referenced this pull request Mar 12, 2026
…io#2758)

* Add function to determine billableAction count

* Make the event history table better

* Add date to pending activity

* Add line-dot visualization back

* Remove borders, more table stuff

* Event Card

* Table changes

* WIP: icon placeholder and isCloud check

* Add dollar-invoice icon

* Show row details on Timeline to make them consistent

* Change grid if no payloads

* Fix timestamp and copyable button

* Fix type, comment out visibility store

* Use h-9 for the table header cell height to prevent shift on bulk actions

* Make title text bigger

* Update Card styles, add event links

* Include workflow rejected action

* Flip visibility to test

* Clean up cards

* Hide redudent fields

* Pending Activities fixes

* Update signal count on id

* UI improvements

* Add PendingNexusOperationCard

* Add check for WorkflowTaskFailedEvent due to reset and update billable actions accordingly

* Refactor to add shouldNotAddBillableAction check instead of resetBillableActionsBeforeEvent

* Fix formatDate to account for already formated date strings

* Use findLast for isWorkflowTaskFailedEventDueToReset

* Reset isCloud

* Event row UI improvements

* More UI fixes

* Remove borders on tables

* Remove nested css for ui-server (temporalio#2767)

* Deployment Versioning Updates (temporalio#2764)

* Svelte5 updates, cleanup. Need new API to convert deployment stuff

* Update deploys SAs to be filter/copyable, add Build Ids everywhere. Add new types

* Fix columns and headers to not have status as column

* Fix table widths, link to task queue show since current/ramping

* Remove console.log, add unit tests for version

* Set width and text-right on link column

* Add latest deployment build id and svelte5

* Use correct translation for ramping version

* Remove comment

* Update column to Actions and update link label

* Show __unversioned__, check if latestId is currentId

* Move back to Pre-Release tag

* Create Version Bump PR as Draft (temporalio#2769)

Some of the required checks dont run when its generated by github actions. The
always draft trick worked in cloud so lets try that in ui as well. This also
sets the author and committer to the user who created the PR.

* chore: bump version to 2.38.0 (temporalio#2770)

Auto-generated version bump from 2.37.2 to 2.38.0

Bump type: minor

Changes included:\nManual version bump

Co-authored-by: Alex-Tideman <7967403+Alex-Tideman@users.noreply.github.com>

* Revert temporalio#2709 due to CORS Issues (temporalio#2772)

* chore: bump version to 2.38.1 (temporalio#2773)

Auto-generated version bump from 2.38.0 to 2.38.1

Bump type: patch

Changes included:\nManual version bump

Co-authored-by: Alex-Tideman <7967403+Alex-Tideman@users.noreply.github.com>

* Make w-1/2 for event card split, fix summary field alignment

* Fix empty row colspan

* Update billing logic, remove dollar-invoice icon

* Check for version change SA

* Update event card spacing

* Update billing logic for schedules, add comments, more event card css

* Fix logic

* Better optional chaining

* Schedule count to 3, remove external signal

* Update to Billable Actions label

* More card spacing updates

* Remove Workers/Versioning tab on task queue page (temporalio#2783)

---------

Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
Co-authored-by: Ross Nelson <ross.nelson@temporal.io>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants