Skip to content

encode nexus id param to avoid error#3054

Closed
andrewzamojc wants to merge 1 commit intomainfrom
encode-nexus-id-param
Closed

encode nexus id param to avoid error#3054
andrewzamojc wants to merge 1 commit intomainfrom
encode-nexus-id-param

Conversation

@andrewzamojc
Copy link
Copy Markdown
Contributor

Description & motivation 💭

Even thought a nexus id should not have a slash in it, some nexus ids do! This PR encodes the id param so if it has special characters they are preserved.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
holocene Ready Ready Preview Comment Dec 9, 2025 10:39pm

@temporal-cicd
Copy link
Copy Markdown
Contributor

temporal-cicd bot commented Dec 9, 2025

Warnings
⚠️

📊 Strict Mode: 1 error in 1 file (0.1% of 1383 total)

src/lib/utilities/route-for.ts (1)
  • L130:4: Type 'string | undefined' is not assignable to type 'string'.

Generated by 🚫 dangerJS against 96ab082

@andrewzamojc
Copy link
Copy Markdown
Contributor Author

Won't do atm. Fixing in #3055 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant