Skip to content

DT-3507-fix-code-block-scrolling #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewzamojc merged 3 commits into from
Feb 3, 2026
Merged

DT-3507-fix-code-block-scrolling #3129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ee7146
add storybook test case for code block scrolling
andrewzamojc Jan 15, 2026
8915af5
remove overflow behaviour property from .cm-scroller in code block st…
andrewzamojc Jan 15, 2026
b768db6
touch up story
andrewzamojc Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/lib/holocene/code-block.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,3 +366,29 @@ var myClient = TemporalClient.ConnectAsync(new("<endpoint>")
copyable: false,
}}
/>

<Story name="Test page scrolling">
<div>
<p>
content<br />
content<br />
content<br />
content<br />
content<br />
content<br />
content<br />
content
</p>
<CodeBlock copyable language="json" content={largeJson} maxHeight={300} />
<p>
content<br />
content<br />
content<br />
content<br />
content<br />
content<br />
content<br />
content
</p>
</div>
</Story>
1 change: 0 additions & 1 deletion src/lib/vendor/codemirror/custom-extensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ const baseTheme = {
// Ensure inner scroller reliably captures wheel/touchpad scroll,
// especially on Firefox with mouse wheels.
overflow: 'auto',
overscrollBehavior: 'contain',
},
'.cm-content': {
caretColor: css('--color-text-primary'),
Expand Down
Loading