Skip to content

DT-3507-fix-code-block-scrolling#3129

Merged
andrewzamojc merged 3 commits intomainfrom
DT-3507-fix-code-block-scrolling
Feb 3, 2026
Merged

DT-3507-fix-code-block-scrolling#3129
andrewzamojc merged 3 commits intomainfrom
DT-3507-fix-code-block-scrolling

Conversation

@andrewzamojc
Copy link
Contributor

@andrewzamojc andrewzamojc commented Feb 2, 2026

Description & motivation 💭

When our code block component has a lot of content and a max-height, it gets a vertical scroll bar. This scroll area doesn't allow scrolling to pass through, which ends up feeling weird in a lot of cases. Furthermore, since some of our pages have little extra scroll heights, sometimes users feel they can't scroll at all.

This PR removes the scrollBehavior: contain from the code block CSS, to allow scrolling to pass through when at the top or bottom of the code block.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Go to holocene preview, code block component, scrolling story. Notice the scroll passes through once you're at the top or bottom of the code.

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 2, 2026 8:32pm

Request Review

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Feb 2, 2026

Warnings
⚠️

📊 Strict Mode: 14 errors in 2 files (1.2% of 1121 total)

src/lib/vendor/codemirror/custom-extensions.ts (4)
  • L61:48: Parameter 'header' implicitly has an 'any' type.
  • L65:6: Type '{ borderWidth?: undefined; borderColor?: undefined; color: string; backgroundColor: string; height: string; } | { borderWidth: string; borderColor: string; color: string; backgroundColor: string; height: string; }' is not assignable to type 'StyleSpec'.
  • L84:6: Type '{ borderWidth?: undefined; borderColor?: undefined; color: string; backgroundColor: string; height: string; } | { borderWidth: string; borderColor: string; color: string; backgroundColor: string; height: string; }' is not assignable to type 'StyleSpec'.
  • L150:2: Property 'text' does not exist on type '{ json: LanguageSupport; java: LanguageSupport; go: LanguageSupport; php: LanguageSupport; python: StreamLanguage; shell: StreamLanguage<...>; dotnet: StreamLanguage<...>; ruby: StreamLanguage<...>; typescript: StreamLanguage<...>; }'.
src/lib/holocene/code-block.stories.svelte (10)
  • L84:44: Argument of type 'null' is not assignable to parameter of type '((key: string, value: { hello: string; }) => { hello: string; }) | undefined'.
  • L112:36: Argument of type 'null' is not assignable to parameter of type '((key: string, value: Record<string, unknown>) => Record<string, unknown>) | undefined'.
  • L133:53: Argument of type 'null' is not assignable to parameter of type '((key: string, value: { hello: string; }) => { hello: string; }) | undefined'.
  • L149:53: Argument of type 'null' is not assignable to parameter of type '((key: string, value: { hello: string; }) => { hello: string; }) | undefined'.
  • L157:53: Argument of type 'null' is not assignable to parameter of type '((key: string, value: { hello: string; }) => { hello: string; }) | undefined'.
  • L167:53: Argument of type 'null' is not assignable to parameter of type '((key: string, value: { hello: string; }) => { hello: string; }) | undefined'.
  • L177:6: Argument of type 'null' is not assignable to parameter of type '((key: string, value: TypedPropertyDescriptor[] & { [x: string]: PropertyDescriptor; }) => TypedPropertyDescriptor[] & { ...; }) | undefined'.
  • L189:6: Argument of type 'null' is not assignable to parameter of type '((key: string, value: TypedPropertyDescriptor[] & { [x: string]: PropertyDescriptor; }) => TypedPropertyDescriptor[] & { ...; }) | undefined'.
  • L344:8: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ 'File A': string; 'File B': string; }'.
  • L345:8: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ 'File A': string; 'File B': string; }'.

Generated by 🚫 dangerJS against b768db6

@andrewzamojc andrewzamojc force-pushed the DT-3507-fix-code-block-scrolling branch from d50c33a to b768db6 Compare February 2, 2026 20:31
@andrewzamojc andrewzamojc marked this pull request as ready for review February 2, 2026 20:32
@andrewzamojc andrewzamojc requested review from a team and rossedfort as code owners February 2, 2026 20:32
@andrewzamojc andrewzamojc merged commit 6209f9b into main Feb 3, 2026
17 of 26 checks passed
@andrewzamojc andrewzamojc deleted the DT-3507-fix-code-block-scrolling branch February 3, 2026 18:16
temporal-cicd bot pushed a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
temporal-cicd bot pushed a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
- [`138473c6`](138473c) Set API to v1.60.1 (#3134)
laurakwhit added a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
- [`138473c6`](138473c) Set API to v1.60.1 (#3134)

Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants