Skip to content

Codefreeze 03.02.26 to main#3213

Merged
Alex-Tideman merged 3 commits intomainfrom
codefreeze-03.02.26
Mar 9, 2026
Merged

Codefreeze 03.02.26 to main#3213
Alex-Tideman merged 3 commits intomainfrom
codefreeze-03.02.26

Conversation

@Alex-Tideman
Copy link
Collaborator

Description & motivation 💭

#3212
#3207
#3206

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

laurakwhit and others added 3 commits March 2, 2026 13:28
* Remove double resolve from routeFor fns

* Add gotoResolved to fix eslint error and keep type safety

* Turn off svelte/no-navigation-without-resolve rule
* Add .omc to gitignore

* Remove full .omc directory
* Fix timestamp filter inputs not pre-filling with previous values

Parse the existing filter ISO value back into date/time components
when reopening a datetime filter chip. Also initialize the "add new
filter" datetime inputs from persisted stores.

* Extract datetime filter parsing into utility with unit tests

Move getInitialStart/getInitialEnd into a shared utility file
and add 12 unit tests covering single datetime, BETWEEN ranges,
timezone conversion, and edge cases.

* Make timezone and initial datetime values reactive with $derived

* Refactor to use consolidated start/end objects and account for timezone changes

---------

Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
@Alex-Tideman Alex-Tideman requested review from a team and rossedfort as code owners March 9, 2026 14:02
@vercel
Copy link

vercel bot commented Mar 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Mar 9, 2026 2:03pm

Request Review

@@ -3,6 +3,7 @@

import { addHours, addMinutes, addSeconds, startOfDay } from 'date-fns';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Could not find a declaration file for module 'date-fns-tz'. '/home/runner/work/ui/ui/node_modules/.pnpm/date-fns-tz@1.3.8_date-fns@2.30.0/node_modules/date-fns-tz/index.js' implicitly has an 'any' type.

@@ -0,0 +1,64 @@
import { startOfDay } from 'date-fns';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Could not find a declaration file for module 'date-fns-tz'. '/home/runner/work/ui/ui/node_modules/.pnpm/date-fns-tz@1.3.8_date-fns@2.30.0/node_modules/date-fns-tz/index.js' implicitly has an 'any' type.

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Mar 9, 2026

Warnings
⚠️

📊 Strict Mode: 40 errors in 4 files (3.6% of 1110 total)

src/lib/stores/schedules.ts (34)
  • L54:4: 'body.schedule' is possibly 'undefined'.
  • L54:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
  • L55:4: 'body.schedule' is possibly 'undefined'.
  • L55:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
  • L56:4: 'body.schedule' is possibly 'undefined'.
  • L56:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
  • L58:42: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  • L60:4: 'body.schedule' is possibly 'undefined'.
  • L60:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
  • L63:4: 'body.schedule' is possibly 'undefined'.
  • L63:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
  • L64:4: 'body.schedule' is possibly 'undefined'.
  • L64:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
  • L71:4: 'body.schedule' is possibly 'undefined'.
  • L71:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
  • L82:4: 'body.schedule' is possibly 'undefined'.
  • L82:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
  • L83:4: 'body.schedule' is possibly 'undefined'.
  • L83:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
  • L115:65: Property 'message' does not exist on type '{}'.
  • L122:4: Type '{ indexedFields: { indexedFields?: { [k: string]: IPayload; } | null | undefined; }; } | null' is not assignable to type 'ISearchAttributes | null | undefined'.
  • L142:10: Type '{ indexedFields: { indexedFields?: { [k: string]: IPayload; } | null | undefined; }; } | null' is not assignable to type 'ISearchAttributes | null | undefined'.
  • L143:12: 'workflowSearchAttributes' is possibly 'undefined'.
  • L147:43: Argument of type '{ type: "Unspecified" | "Keyword" | "Text" | "Int" | "Double" | "Bool" | "KeywordList" | "Datetime"; label: string; value?: any; }[] | undefined' is not assignable to parameter of type '{ type: "Unspecified" | "Keyword" | "Text" | "Int" | "Double" | "Bool" | "KeywordList" | "Datetime"; label: string; value?: any; }[]'.
  • L204:65: Property 'message' does not exist on type '{}'.
  • L212:4: Type '{ indexedFields: { indexedFields?: { [k: string]: IPayload; } | null | undefined; }; } | null' is not assignable to type 'ISearchAttributes | null | undefined'.
  • L217:13: 'schedule.action' is possibly 'null' or 'undefined'.
  • L222:10: Type '{ indexedFields: { indexedFields?: { [k: string]: IPayload; } | null | undefined; }; } | null' is not assignable to type 'ISearchAttributes | null | undefined'.
  • L228:17: 'body.schedule' is possibly 'undefined'.
  • L228:17: 'body.schedule.action' is possibly 'null' or 'undefined'.
  • L240:65: Property 'message' does not exist on type '{}'.
  • L246:4: 'body.schedule' is possibly 'undefined'.
  • L249:4: 'body.schedule' is possibly 'undefined'.
  • L249:4: 'body.schedule.spec' is possibly 'null' or 'undefined'.
src/lib/utilities/query/datetime-filter-parse.ts (1)
  • L1:31: Could not find a declaration file for module 'date-fns-tz'. '/home/runner/work/ui/ui/node_modules/.pnpm/date-fns-tz@1.3.8_date-fns@2.30.0/node_modules/date-fns-tz/index.js' implicitly has an 'any' type.
src/lib/components/search-attribute-filter/datetime-filter.svelte (1)
  • L2:33: Could not find a declaration file for module 'date-fns-tz'. '/home/runner/work/ui/ui/node_modules/.pnpm/date-fns-tz@1.3.8_date-fns@2.30.0/node_modules/date-fns-tz/index.js' implicitly has an 'any' type.
src/lib/components/workflow/filter-bar/dropdown-filter-chip.svelte (4)
  • L4:33: Could not find a declaration file for module 'date-fns-tz'. '/home/runner/work/ui/ui/node_modules/.pnpm/date-fns-tz@1.3.8_date-fns@2.30.0/node_modules/date-fns-tz/index.js' implicitly has an 'any' type.
  • L316:12: Type 'null' is not assignable to type 'string'.
  • L65:4: Type 'null' is not assignable to type 'number'.
  • L192:24: Parameter 'e' implicitly has an 'any' type.

Generated by 🚫 dangerJS against c844d81

@Alex-Tideman Alex-Tideman requested a review from laurakwhit March 9, 2026 15:15
@Alex-Tideman Alex-Tideman merged commit 954c647 into main Mar 9, 2026
20 checks passed
temporal-cicd bot pushed a commit that referenced this pull request Mar 10, 2026
Auto-generated version bump from 2.47.2 to 2.47.3

Bump type: patch

Changes included:
- [`115e9f4f`](115e9f4) always show create schedule button when 0 schedules (#3205)
- [`ee254fb1`](ee254fb) Revert Count Schedules API (#3203)
- [`954c647e`](954c647) Codefreeze 03.02.26 to main (#3213)
- [`93f0e8f4`](93f0e8f) Fix custom search attributes inputs for different attribute types (#3215)
laurakwhit added a commit that referenced this pull request Mar 10, 2026
Auto-generated version bump from 2.47.2 to 2.47.3

Bump type: patch

Changes included:
- [`115e9f4f`](115e9f4) always show create schedule button when 0 schedules (#3205)
- [`ee254fb1`](ee254fb) Revert Count Schedules API (#3203)
- [`954c647e`](954c647) Codefreeze 03.02.26 to main (#3213)
- [`93f0e8f4`](93f0e8f) Fix custom search attributes inputs for different attribute types (#3215)

Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants