Skip to content

Display Principal fields in Event History#3272

Merged
Alex-Tideman merged 6 commits intomainfrom
principal-field
Apr 6, 2026
Merged

Display Principal fields in Event History#3272
Alex-Tideman merged 6 commits intomainfrom
principal-field

Conversation

@Alex-Tideman
Copy link
Copy Markdown
Collaborator

@Alex-Tideman Alex-Tideman commented Apr 6, 2026 •
edited
Loading

Description & motivation 💭

Display the Principal Name and Principal Type field that is returned from the server in the event history if the fields exist.

Requires bump to v1.62.6 for API but can be safely rolled out before that version is available in server.

Screenshots (if applicable) 📸

Screenshot 2026-04-06 at 2 27 13 PM Screenshot 2026-04-06 at 2 27 33 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested a review from laurakwhit April 6, 2026 19:41
@Alex-Tideman Alex-Tideman requested review from a team and rossedfort as code owners April 6, 2026 19:41
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Apr 6, 2026 7:52pm

Request Review

@temporal-cicd
Copy link
Copy Markdown
Contributor

temporal-cicd bot commented Apr 6, 2026 •
edited
Loading

Warnings
⚠️

📊 Strict Mode: 30 errors in 3 files (2.8% of 1085 total)

src/lib/models/event-history/index.ts (6)
  • L42:45: Argument of type 'EventAttribute | IFailure | PotentiallyDecodable' is not assignable to parameter of type 'Optional<WorkflowEvent | EventAttribute | PotentiallyDecodable>'.
  • L134:9: The operand of a 'delete' operator must be optional.
  • L135:9: The operand of a 'delete' operator must be optional.
  • L136:9: The operand of a 'delete' operator must be optional.
  • L137:9: The operand of a 'delete' operator must be optional.
  • L138:9: The operand of a 'delete' operator must be optional.
src/lib/utilities/format-event-attributes.ts (13)
  • L81:38: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CombinedAttributes'.
  • L82:58: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CombinedAttributes'.
  • L86:10: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CombinedAttributes'.
  • L91:10: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CombinedAttributes'.
  • L95:11: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CombinedAttributes'.
  • L105:25: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CombinedAttributes'.
  • L118:46: No overload matches this call.
  • L120:25: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CombinedAttributes'.
  • L126:42: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CombinedAttributes'.
  • L150:23: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CombinedAttributes'.
  • L209:9: Type '("userMetadata" | "workflowExecutionStartedEventAttributes" | "workflowExecutionCompletedEventAttributes" | "workflowExecutionFailedEventAttributes" | "workflowExecutionTimedOutEventAttributes" | ... 54 more ... | "workflowExecutionUnpausedEventAttributes")[] | undefined' must have a 'Symbol.iterator' method that returns an iterator.
  • L232:6: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Partial<Record<AttributeGroup, ("userMetadata" | "workflowExecutionStartedEventAttributes" | "workflowExecutionCompletedEventAttributes" | "workflowExecutionFailedEventAttributes" | ... 55 more ... | "workflowExecutionUnpausedEventAttributes")[]>>'.
  • L259:34: 'groupedAttributes.summary' is possibly 'undefined'.
src/lib/components/event/event-card.svelte (11)
  • L130:37: Type 'string | null | undefined' is not assignable to type 'string'.
  • L130:48: 'link.workflowEvent' is possibly 'null' or 'undefined'.
  • L138:6: Type 'string | null | undefined' is not assignable to type 'string'.
  • L138:15: 'link.workflowEvent' is possibly 'null' or 'undefined'.
  • L141:10: 'link.workflowEvent' is possibly 'null' or 'undefined'.
  • L169:19: Parameter 'key' implicitly has an 'any' type.
  • L169:24: Parameter 'value' implicitly has an 'any' type.
  • L230:15: Parameter 'key' implicitly has an 'any' type.
  • L230:20: Parameter 'value' implicitly has an 'any' type.
  • L250:18: Parameter 'key' implicitly has an 'any' type.
  • L250:23: Parameter 'value' implicitly has an 'any' type.

Generated by 🚫 dangerJS against 22b08fb

@Alex-Tideman Alex-Tideman changed the title Principal fields Display Principal fields in Event History Apr 6, 2026
@Alex-Tideman Alex-Tideman merged commit dfff353 into main Apr 6, 2026
17 checks passed
@Alex-Tideman Alex-Tideman deleted the principal-field branch April 6, 2026 20:09
temporal-cicd bot pushed a commit that referenced this pull request Apr 10, 2026
@laurakwhit
chore: bump version to 2.48.2
02361da 
Auto-generated version bump from 2.48.1 to 2.48.2

Specific version: 2.48.2

Changes included:
- [`92cd681e`](92cd681) Re-wire auth to use a provider pattern. Lots of tests remove cloud references (#3230)
- [`3d92202b`](3d92202) Use --top-nav-height CSS variable for sticky element positioning (#3250)
- [`16295986`](1629598) Bump saved view limits from 20 to 50 (#3254)
- [`a9fa0e91`](a9fa0e9) Display cron string instead of calendar spec when schedule has a cron string in comment field (#3241)
- [`f1811715`](f181171) use full for 100% instead of 100vh (#3256)
- [`0dfadd74`](0dfadd7) Add samples-ruby to workflows table empty state (#3259)
- [`d85d61a3`](d85d61a) Display human-readable schedule spec labels (#3261)
- [`b63049c5`](b63049c) Add invite icon to Holocene design system (#3262)
- [`00c6418c`](00c6418) Bump google.golang.org/grpc from 1.66.1 to 1.79.3 in /server (#3232)
- [`b04a3676`](b04a367) Add back animation (#3251)
- [`7b651524`](7b65152) Bump github.com/go-jose/go-jose/v4 from 4.1.3 to 4.1.4 in /server (#3268)
- [`45f4fdea`](45f4fde) use snippets for nexus CTAs (#3266)
- [`420f5c9d`](420f5c9) min-h-full instead of screen (#3270)
- [`f5b2fab6`](f5b2fab) feat(navigation): add NavSection Holocene component (#3263)
- [`657b2728`](657b272) Adds requested design changes to breadcrumb items (#3267)
- [`6763cc4d`](6763cc4) Remove serena (#3273)
- [`dfff353e`](dfff353) Display Principal fields in Event History (#3272)
- [`2d289bce`](2d289bc) Update CODEOWNERS to wildcard for temporalio/frontend-engineering (#3275)
- [`a2eaf16e`](a2eaf16) Persist workflow view and sort order preferences across navigation (#3260)
- [`c5d4c996`](c5d4c99) Add link from Event Card to jump to event id page from Timeline. Remove unnecessary padding (#3277)
- [`e5b3ea55`](e5b3ea5) fix(deps): upgrade lodash, svelte, kit, storybook, tar-fs for security (#3269)
- [`b44afbe6`](b44afbe) fix(deps): upgrade vite and add picomatch/svgo overrides for security (#3279)
- [`4e8cb4e9`](4e8cb4e) Fix unpause confirmation modal title (#3280)
- [`740b3529`](740b352) Add Slack notification when DESIGN FEEDBACK REQUESTED label is added to a PR (#3282)
- [`7e8170e4`](7e8170e) Add check for COLLABORATOR (#3283)
- [`dc27109d`](dc27109) fix: update nav item margin from mb-1 to mb-2 (#3290)
- [`3e6416d2`](3e6416d) Pass execution runId in workflow request for schedule recent run (#3289)
- [`ae3a1844`](ae3a184) Fix schedule edit double-encoding header fields (#3287)
- [`09c083e0`](09c083e) fix: prevent reset modal from closing on authorization error (#3291)
- [`0aa3b72b`](0aa3b72) Sort namespace picker alphabetically (#3286)
- [`4c3d0057`](4c3d005) Sort alphabetically utility (#3293)
- [`67a988b9`](67a988b) Bump @sveltejs/kit from 2.55.0 to 2.57.1 (#3294)
@temporal-cicd temporal-cicd bot mentioned this pull request Apr 10, 2026
Merged
laurakwhit added a commit that referenced this pull request Apr 10, 2026
@temporal-cicd @laurakwhit
chore: bump version to 2.48.2 (#3295)
dce87ac 
Auto-generated version bump from 2.48.1 to 2.48.2

Specific version: 2.48.2

Changes included:
- [`92cd681e`](92cd681) Re-wire auth to use a provider pattern. Lots of tests remove cloud references (#3230)
- [`3d92202b`](3d92202) Use --top-nav-height CSS variable for sticky element positioning (#3250)
- [`16295986`](1629598) Bump saved view limits from 20 to 50 (#3254)
- [`a9fa0e91`](a9fa0e9) Display cron string instead of calendar spec when schedule has a cron string in comment field (#3241)
- [`f1811715`](f181171) use full for 100% instead of 100vh (#3256)
- [`0dfadd74`](0dfadd7) Add samples-ruby to workflows table empty state (#3259)
- [`d85d61a3`](d85d61a) Display human-readable schedule spec labels (#3261)
- [`b63049c5`](b63049c) Add invite icon to Holocene design system (#3262)
- [`00c6418c`](00c6418) Bump google.golang.org/grpc from 1.66.1 to 1.79.3 in /server (#3232)
- [`b04a3676`](b04a367) Add back animation (#3251)
- [`7b651524`](7b65152) Bump github.com/go-jose/go-jose/v4 from 4.1.3 to 4.1.4 in /server (#3268)
- [`45f4fdea`](45f4fde) use snippets for nexus CTAs (#3266)
- [`420f5c9d`](420f5c9) min-h-full instead of screen (#3270)
- [`f5b2fab6`](f5b2fab) feat(navigation): add NavSection Holocene component (#3263)
- [`657b2728`](657b272) Adds requested design changes to breadcrumb items (#3267)
- [`6763cc4d`](6763cc4) Remove serena (#3273)
- [`dfff353e`](dfff353) Display Principal fields in Event History (#3272)
- [`2d289bce`](2d289bc) Update CODEOWNERS to wildcard for temporalio/frontend-engineering (#3275)
- [`a2eaf16e`](a2eaf16) Persist workflow view and sort order preferences across navigation (#3260)
- [`c5d4c996`](c5d4c99) Add link from Event Card to jump to event id page from Timeline. Remove unnecessary padding (#3277)
- [`e5b3ea55`](e5b3ea5) fix(deps): upgrade lodash, svelte, kit, storybook, tar-fs for security (#3269)
- [`b44afbe6`](b44afbe) fix(deps): upgrade vite and add picomatch/svgo overrides for security (#3279)
- [`4e8cb4e9`](4e8cb4e) Fix unpause confirmation modal title (#3280)
- [`740b3529`](740b352) Add Slack notification when DESIGN FEEDBACK REQUESTED label is added to a PR (#3282)
- [`7e8170e4`](7e8170e) Add check for COLLABORATOR (#3283)
- [`dc27109d`](dc27109) fix: update nav item margin from mb-1 to mb-2 (#3290)
- [`3e6416d2`](3e6416d) Pass execution runId in workflow request for schedule recent run (#3289)
- [`ae3a1844`](ae3a184) Fix schedule edit double-encoding header fields (#3287)
- [`09c083e0`](09c083e) fix: prevent reset modal from closing on authorization error (#3291)
- [`0aa3b72b`](0aa3b72) Sort namespace picker alphabetically (#3286)
- [`4c3d0057`](4c3d005) Sort alphabetically utility (#3293)
- [`67a988b9`](67a988b) Bump @sveltejs/kit from 2.55.0 to 2.57.1 (#3294)

Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rossedfort rossedfort rossedfort approved these changes

@laurakwhit laurakwhit Awaiting requested review from laurakwhit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alex-Tideman @rossedfort