Skip to content

refactor(DT-3906): UI svelte 5 migrate components/events#3365

Merged
tegan-temporal merged 3 commits intocodefreeze-05.01.26from
DT-3906-ui-svelte-5-migrate-components-events
May 4, 2026
Merged

refactor(DT-3906): UI svelte 5 migrate components/events#3365
tegan-temporal merged 3 commits intocodefreeze-05.01.26from
DT-3906-ui-svelte-5-migrate-components-events

Conversation

@tegan-temporal
Copy link
Copy Markdown
Contributor

Description & motivation 💭

Migrate components/events files from legacy to runes syntax

@tegan-temporal tegan-temporal self-assigned this May 4, 2026
@tegan-temporal tegan-temporal requested a review from a team as a code owner May 4, 2026 19:33
@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment May 4, 2026 7:41pm

Request Review

@temporal-cicd
Copy link
Copy Markdown
Contributor

temporal-cicd Bot commented May 4, 2026

Warnings
⚠️

📊 Strict Mode: 21 errors in 3 files (2.1% of 981 total)

src/lib/components/event/event-card.svelte (11)
  • L141:37: Type 'string | null | undefined' is not assignable to type 'string'.
  • L141:48: 'link.workflowEvent' is possibly 'null' or 'undefined'.
  • L149:6: Type 'string | null | undefined' is not assignable to type 'string'.
  • L149:15: 'link.workflowEvent' is possibly 'null' or 'undefined'.
  • L152:10: 'link.workflowEvent' is possibly 'null' or 'undefined'.
  • L178:19: Parameter 'key' implicitly has an 'any' type.
  • L178:24: Parameter 'value' implicitly has an 'any' type.
  • L239:15: Parameter 'key' implicitly has an 'any' type.
  • L239:20: Parameter 'value' implicitly has an 'any' type.
  • L259:18: Parameter 'key' implicitly has an 'any' type.
  • L259:23: Parameter 'value' implicitly has an 'any' type.
src/lib/components/event/event-summary-row.svelte (5)
  • L134:6: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  • L171:23: Parameter 'event' implicitly has an 'any' type.
  • L183:30: Parameter 'group' implicitly has an 'any' type.
  • L183:37: Parameter 'hoveredEventId' implicitly has an 'any' type.
  • L311:16: Type 'ITimestamp | null | undefined' is not assignable to type 'ITimestamp'.
src/lib/components/lines-and-dots/svg/timeline-graph-row.svelte (5)
  • L95:20: 'distance' is possibly 'null'.
  • L95:31: 'workflowDistance' is possibly 'null'.
  • L106:20: 'distance' is possibly 'null'.
  • L106:31: 'workflowDistance' is possibly 'null'.
  • L241:12: 'pendingActivity.attempt' is possibly 'null' or 'undefined'.

Generated by 🚫 dangerJS against 061d469

Copy link
Copy Markdown
Contributor

@GraceGardner GraceGardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tegan-temporal tegan-temporal merged commit 843af0c into codefreeze-05.01.26 May 4, 2026
15 checks passed
@tegan-temporal tegan-temporal deleted the DT-3906-ui-svelte-5-migrate-components-events branch May 4, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants