fix(a11y): use empty alt on decorative SDK logo image#3424
Merged
Conversation
The SDK logo `<img>` inside `aria-hidden="true"` had `alt="SDK Icon"` which is misleading if the wrapper is ever removed. Empty alt correctly marks it as decorative. The sibling text node already provides the SDK identity. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bilal-karim
changed the title
Alex-Tideman
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alt="SDK Icon"toalt=""on the decorative SDK logo<img>insdk-logo.sveltearia-hidden="true"so the alt text is already excluded from the accessibility tree, butalt="SDK Icon"is misleading and could become a real WCAG 1.1.1 defect if the wrapper is ever refactored{sdk} {version}) already provides the SDK identity to screen readersTest plan
🤖 Generated with Claude Code