fix(a11y): info-and-relationships compliance (WCAG 1.3.1)#3432
Merged
Conversation
Four related fixes under SC 1.3.1, grouped per the audit's correction of the matrix pathway: - NumberInput / Textarea: forward `required` to the underlying native element. Previously the visual red-dot appeared via <Label> but the field was not programmatically required, so AT users heard an optional-field announcement despite the visible indicator. - RadioGroup: add role="radiogroup" and link the optional description via aria-labelledby so AT users hear the group as a whole rather than each radio in isolation. - Tables: add scope="col" to every <th> in product data tables (workflows, schedules, workers, batch-operations, child/parent workflow relationships). Fixes WCAG technique H63. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
3 tasks
ardiewen
approved these changes
May 29, 2026
…ionships # Conflicts: # src/lib/holocene/input/number-input.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundled SC 1.3.1 fixes (audit groups them per SC):
NumberInput/Textarea— forwardrequiredto native element. Visual red-dot was already shown via<Label>, but native HTMLrequiredwas missing, so AT users heard an optional-field announcement despite the visible indicator. One-line fix per primitive.RadioGroup— group semantics. Addedrole="radiogroup"and linked the optionaldescriptionviaaria-labelledbyso AT users hear the group as a whole rather than each radio in isolation.scope="col"on every<th>. Workflow lists, schedule lists, workers, batch-operations, child/parent workflow relationships. Fixes WCAG technique H63. Includes the two reusable header-cell primitives so future configurable-table consumers get it for free.Audit context
audit-output/issues/1.3.1-{number-input,textarea}-required-forwarding.md,1.3.1-radio-group-role-and-labelling.md,1.3.1-table-scope-attributes.md.1.4.1-label-required-indicator.mdwhich depends on the two forwarding fixes shipping first.Files (14)
src/lib/holocene/input/number-input.svelte—{required}on<input>src/lib/holocene/textarea.svelte—{required}on<textarea>src/lib/holocene/radio-input/radio-group.svelte— role + aria-labelledby wiringscope="col"on<th>Test plan
NumberInput/Textarea(e.g. activity-options-update-drawer); screen reader announces "required".RadioGroup(schedule retention, start-workflow input encoding); screen reader announces ", radiogroup" when entering the first radio./namespaces/<ns>/workflows, schedules, workers), navigate cells; AT announces column headers ("Status, column 1").pnpm exec playwright test tests/accessibility/— axe rulesaria-required-attr,aria-required-children,scope-attr-valid,td-has-headershould not flag the touched surfaces.🤖 Generated with Claude Code
A11y-Audit-Ref: 1.3.1-number-input-required-forwarding
A11y-Audit-Ref: 1.3.1-textarea-required-forwarding
A11y-Audit-Ref: 1.3.1-radio-group-role-and-labelling
A11y-Audit-Ref: 1.3.1-table-scope-attributes