Skip to content

fix(a11y): consistent high-contrast focus rings across all Button variants (WCAG 1.4.11) #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bilal-karim merged 2 commits into from
May 22, 2026
Merged

fix(a11y): consistent high-contrast focus rings across all Button variants (WCAG 1.4.11) #3438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83fe164
fix(a11y): high-contrast focus rings on primary and destructive butto…
bilal-karim May 22, 2026
821ed18
fix(a11y): apply consistent focus-ring pattern across all Button vari…
bilal-karim May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/lib/holocene/button.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@
variants: {
variant: {
primary:
'surface-interactive border-transparent text-white focus-visible:ring-primary/70 data-[active=true]:bg-subtle data-[active=true]:text-primary',
'surface-interactive border-transparent text-white focus-visible:ring-primary focus-visible:ring-offset-2 focus-visible:ring-offset-surface-primary data-[active=true]:bg-subtle data-[active=true]:text-primary',
secondary:
'surface-primary border-subtle focus-visible:ring-primary/70 hover:surface-interactive-secondary focus-visible:surface-interactive-secondary data-[active=true]:bg-subtle',
'surface-primary border-subtle focus-visible:ring-primary focus-visible:ring-offset-2 focus-visible:ring-offset-surface-primary hover:surface-interactive-secondary focus-visible:surface-interactive-secondary data-[active=true]:bg-subtle',
destructive:
'surface-interactive-danger border-transparent focus-visible:ring-danger/70 data-[active=true]:surface-interactive-danger',
'surface-interactive-danger border-transparent focus-visible:ring-danger focus-visible:ring-offset-2 focus-visible:ring-offset-surface-primary data-[active=true]:surface-interactive-danger',
ghost:
'bg-transparent border-transparent text-primary hover:surface-interactive-ghost focus-visible:surface-interactive-ghost focus-visible:ring-primary/70 data-[active=true]:bg-subtle',
'bg-transparent border-transparent text-primary hover:surface-interactive-ghost focus-visible:surface-interactive-ghost focus-visible:ring-primary focus-visible:ring-offset-2 focus-visible:ring-offset-surface-primary data-[active=true]:bg-subtle',
'table-header':
'bg-transparent border-transparent focus-visible:ring-primary/70 focus-visible:border-transparent',
'bg-transparent border-transparent focus-visible:ring-primary focus-visible:ring-offset-2 focus-visible:ring-offset-surface-primary focus-visible:border-transparent',
},
size: {
xs: 'h-8 text-xs px-2 py-1',
Expand Down
Loading