Make bottom-nav accept linksSnippet instead of sections#3445
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
GiantRobots
approved these changes
May 22, 2026
GiantRobots
approved these changes
May 22, 2026
ardiewen
added a commit
that referenced
this pull request
Jun 3, 2026
…AG 1.3.2) Reimplements the 1.3.2 Meaningful Sequence fix on the linksSnippet architecture introduced by #3445 (which deleted bottom-nav-links.svelte). The drawer used flex-col-reverse to place the primary nav group at the bottom near the thumb, so sighted users read top-to-bottom while AT and keyboard users encountered the reverse DOM order. Move the reversal from CSS into the data: emit the snippet in visual top-to-bottom order (reversed copies of each group) and switch flex-col-reverse/justify-start to flex-col/justify-end. Pixels are unchanged; DOM, tab, and screen-reader order now match the visual order. Copies ([...group].reverse()) are used so the arrays passed to the desktop SideNavigation are not mutated. A11y-Audit-Ref: 1.3.2-bottom-nav-links-order Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 3, 2026
bilal-karim
added a commit
that referenced
this pull request
Jun 3, 2026
…AG 1.3.2) (#3441) Reimplements the 1.3.2 Meaningful Sequence fix on the linksSnippet architecture introduced by #3445 (which deleted bottom-nav-links.svelte). The drawer used flex-col-reverse to place the primary nav group at the bottom near the thumb, so sighted users read top-to-bottom while AT and keyboard users encountered the reverse DOM order. Move the reversal from CSS into the data: emit the snippet in visual top-to-bottom order (reversed copies of each group) and switch flex-col-reverse/justify-start to flex-col/justify-end. Pixels are unchanged; DOM, tab, and screen-reader order now match the visual order. Copies ([...group].reverse()) are used so the arrays passed to the desktop SideNavigation are not mutated. A11y-Audit-Ref: 1.3.2-bottom-nav-links-order Co-authored-by: Ardie Wen <ardie.wen@temporal.io> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ardiewen
added a commit
that referenced
this pull request
Jun 4, 2026
The mobile bottom-nav linksSnippet renders NavigationItem directly, bypassing NavSection's `!item.hidden` filter. As a result, capability- gated links (Standalone Activities on server <1.30.0, Nexus when systemInfo.capabilities.nexus is absent) still rendered as focusable links for keyboard and screen-reader users on incapable servers — the desktop side-nav already filters these via NavSection. This gap was introduced when #3445 flattened NavSection into a snippet of raw NavigationItems; #3434 added the hidden filter to NavSection only. Apply the same `!item.hidden` predicate to both bottom-nav groups. A11y-Audit-Ref: 4.1.2-nav-hidden-flag-ignored Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Enable composability of bottom nav links via snippet instead of passing in an array of sections
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻