Fix task queues fetched twice on workflow#883
Closed
laurakwhit wants to merge 2 commits intomainfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures are unavailable for this run. For more information, see the Cypress Dashboard This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Collaborator
Author
|
Closing this for now. May revisit if this is still an issue after SvelteKit upgrade. |
Collaborator
Author
|
This has been fixed in #984 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
I've removed the
<slot />in favor of conditionally rendering different layouts based on theeventViewType. This doesn't seem like the ideal solution, as we also still need to render them undercompact,feed, andjsoninsrc/routes/.../history🤔Why?
When a user clicks on a workflow in the workflow list and navigates to it the task-queues are fetched twice.
This is because
fetchWorkflowsin subscribe is being called twice in the workflow run store. This is due to the components (e.g.WorkflowHistoryFeed) being passed here (or more specifically here) rendering twice when the page is navigated to.I don't know why they're doing that 😅 Maybe a bug? Maybe a symptom of how we're doing routes and layouts here? Will continue to investigate...
Checklist
Closes: n/a
How was this tested:
historyhistory/feedhistory/compacthistory/json