fix: bump viem/wagmi/tempo.ts to fix e2e, require e2e for merge#159
Closed
fix: bump viem/wagmi/tempo.ts to fix e2e, require e2e for merge#159
Conversation
Co-authored-by: tmm <6759464+tmm@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019cfd05-d8b4-730e-986e-df7a859a9243
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
viem 2.47.x changed default access key internal_version to v2 which breaks WebAuthn sign-up with keys.tempo.xyz. Cap at <2.47.0 while bumping from 2.44.4 to 2.46.3 for latest bug fixes. Co-Authored-By: tmm <6759464+tmm@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019cfd05-d8b4-730e-986e-df7a859a9243
Member
|
Fixed #180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes e2e tests that have been failing since March 9 and adds merge protection.
Motivation
The original e2e failure coincides with
viem@2.47.0being released March 4 (breaking: chainId required for access key auth) andviem@2.47.1on March 9 (default access keyinternal_versionchanged from v1 → v2). Since the docs lockfile pinnedviem@2.44.4,pnpm installwithout--frozen-lockfilein CI could resolve a newer version, and the fee-payer worker was also redeployed with 2.47.x around this time.Bumping to 2.47.x breaks WebAuthn sign-up entirely because
keys.tempo.xyzdoesn't support v2 access keys yet. So the fix is to cap viem below 2.47.0 while bumping to 2.46.3 for latest safe patches.Changes
viemat>=2.44.4 <2.47.0(resolves to 2.46.3) — avoids v2 access key breakagetempo.tsto 0.14.2 (latest in^0.14.0range via lockfile refresh)pnpm install --frozen-lockfilein CI to prevent future version drifte2e-resultsummary job so branch protection can require a singleE2E TestscheckTesting
pnpm run check:typespassesBranch protection (post-merge)
After merging, add a ruleset on
mainrequiring status checksCheckandE2E Tests, with admin bypass enabled. I don't have admin access to create this.Co-Authored-By: tmm 6759464+tmm@users.noreply.github.com
Prompted by: tmm