Closed
Conversation
E2E tests interact with testnet (mint stablecoins, manage roles) and have been failing on main for the last 5+ merges due to testnet flakiness. This unblocks all PRs while the underlying issue is investigated. Co-authored-by: Jennifer <5339211+jenpaff@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d00eb-3068-755a-a642-38bb1977383a
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Fixed #180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make E2E tests non-blocking with
continue-on-error: true.Motivation
E2E tests run on-chain transactions against testnet (mint stablecoins, grant/revoke roles) and have been failing on
mainfor the last 5+ merges — blocking all PRs including unrelated content changes.Changes
continue-on-error: trueto thee2ejob so failures show as warnings, not blockersTesting
N/A — CI config change. E2E tests still run and report results, they just won't block merges.
Prompted by: Jen