fix(e2e): use local webauthn ceremony in E2E tests#279
Merged
brendanjryan merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Remove authUrl from the E2E webAuthn connector config so it falls back to WebAuthnCeremony.local() instead of hitting keys.tempo.xyz. In accounts@0.5.4+, the authUrl option is now correctly forwarded to the adapter (previously silently ignored), which causes E2E tests to call keys.tempo.xyz/register/options — a route that doesn't exist on the key-manager worker. Local ceremonies work with Playwright's CDP virtual authenticator and don't depend on external services.
brendanjryan
force-pushed
the
fix/e2e-local-webauthn
branch
from
f989c8c to
a1c8fa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All E2E tests on
mainhave been failing since PR #259 (accounts0.5.1 → 0.5.4). Every test fails at the sign-in step — clicking "Sign in"/"Sign up" never produces a "Sign out" button.Root Cause
In
accounts@0.5.1, the wagmiwebAuthn()connector had a bug where theauthUrloption was silently ignored — it wasn't destructured or forwarded to the adapter. This meant the E2E config accidentally usedWebAuthnCeremony.local()(browser-side passkey ceremonies), which worked perfectly with Playwright's CDP virtual authenticator.In
accounts@0.5.4, this was fixed —authUrlis now properly forwarded. So the E2E tests started hittinghttps://keys.tempo.xyz/register/options,/login/options, etc. Butkeys.tempo.xyzrunsHandler.keyManager(fromtempo.ts), which serves completely different routes (GET /challenge,GET /:id). All ceremony requests 404, sign-in fails silently, and tests time out.Fix
Remove
authUrlfrom theVITE_E2Ebranch of the wagmi config. This makes the E2E connector useWebAuthnCeremony.local()— the correct behavior for tests with a CDP virtual authenticator. The production config is unchanged.