Skip to content

[codex] fix docs main ci#345

Merged
brendanjryan merged 1 commit intomainfrom
codex/fix-docs-main-ci
Apr 24, 2026
Merged

[codex] fix docs main ci#345
brendanjryan merged 1 commit intomainfrom
codex/fix-docs-main-ci

Conversation

@brendanjryan
Copy link
Copy Markdown
Contributor

@brendanjryan brendanjryan commented Apr 24, 2026

Summary

  • Preserve the native disabled attribute on demo buttons so Playwright and users see the real disabled state.
  • Make the virtual-address E2E test select the Real registration tab before asserting live registration UI.
  • Let WebAuthn root account lookup tolerate passkey connector startup delays before creating zone clients.

Root Cause

Docs main CI was failing in E2E shard 3. The shared demo Button styled disabled buttons but did not pass the disabled attribute to the DOM, so Playwright tried to click controls that were visually disabled and had pointer-events disabled. Once fixed, the withdraw test exposed a startup race where the WebAuthn root account query could fail once and never retry, leaving the zone authorization button permanently disabled. The virtual-address test also assumed the live registration demo was the default tab, but the page defaults to the Fast demo tab.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tempo-docs Ready Ready Preview, Comment Apr 24, 2026 3:53pm

Request Review

@brendanjryan brendanjryan marked this pull request as ready for review April 24, 2026 15:51
@brendanjryan brendanjryan merged commit 7114d5d into main Apr 24, 2026
9 checks passed
@brendanjryan brendanjryan deleted the codex/fix-docs-main-ci branch April 24, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant