docs(node): add consensus listen-address and chain switching info#52
Closed
docs(node): add consensus listen-address and chain switching info#52
Conversation
- Add --consensus.listen-address 0.0.0.0:8000 to validator run command - Add section on switching chains with datadir reset instructions Closes CHAIN-535 Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019c0bfe-1277-7407-ba82-f2ce6a824d26
kuyziss
reviewed
Feb 1, 2026
|
|
||
| ## Switching chains | ||
|
|
||
| When switching between chains (e.g., from Moderato to Presto), use a fresh datadir or delete the existing database: |
Contributor
There was a problem hiding this comment.
shouldn't we also delete the consensus datadir?
Contributor
There was a problem hiding this comment.
also, it feels kind of obvious and might suggest the wrong ideas for people to reuse the same node for different networks, and then many things can go wrong there, because if we specify this, why don't we also specify that when switching chains they should use a different snapshot arg, different args in general etc?
Contributor
Author
There was a problem hiding this comment.
For context was in response to tempoxyz/tempo#2304. Maybe instead of documenting we should find ways to make the UX better when running a tempo node for a different chain e.g. namespaced data dirs
snario
pushed a commit
that referenced
this pull request
Feb 3, 2026
Zygimantass
pushed a commit
that referenced
this pull request
Apr 16, 2026
* docs: add Zones protocol documentation Add comprehensive documentation for the Tempo Zones feature: - Overview: architecture, zone creation, token management, fees - Bridging: deposits, withdrawals, encrypted deposits, composable callbacks - Privacy Zones: execution-level and RPC-level privacy protections - Proving: batch submission, verifier interface, ancestry proofs - Upgrades: hard fork activation, verifier rotation, failure modes Also updates the privacy learn page to reference Zones and adds a Zones card to the protocol index. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): rework overview with intro from design doc Incorporate the high-level intro, system architecture diagrams, contract architecture, trust model table, and creating a zone walkthrough from the zones design document. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * fix: escape angle bracket in MDX to fix build Replace '<10 seconds' with 'under 10 seconds' — the bare '<' was parsed as a JSX tag by the MDX compiler. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): convert ASCII art to mermaid diagrams Replace ASCII art illustrations with native mermaid code blocks, matching the pattern used in validator-config-v1.mdx and validator-config-v2.mdx. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): add note that prover is not yet live Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): clarify withdrawal queue slots contain multiple withdrawals Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * fix(zones): fix mermaid diagram rendering - Replace \n with <br/> for multi-line node labels (mermaid requires HTML) - Reorder edge definitions before subgraphs to fix withdrawal arrow routing through ZoneFactory instead of ZonePortal - Remove redundant edge labels for cleaner system architecture diagram Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): remove queue design rationale paragraph Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): rewrite privacy page, split RPC into own page All zones are private by design — rewrite the privacy page to reflect this rather than treating privacy as a special variant. Move the RPC specification (auth tokens, method access control, timing side channels, event filtering, error codes) into a dedicated /protocol/zones/rpc page. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): remove incorrect contract creation rationale Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): wording fix in proving page Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): wording fix for ancestry proofs Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): note encrypted deposits exception for quantum security Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * Refine overview.mdx (#52) * Refine overview.mdx - consistent terminology (zone vs tempo L1, as opposed to chain, main chain etc). - minor nits/ rewording * Apply suggestion from @dankrad * Apply suggestion from @dankrad --------- Co-authored-by: dankrad <mail@dankradfeist.de> * Update privacy.md for clarity and terminology (#53) * Update privacy.md for clarity and terminology * Apply suggestion from @dankrad --------- Co-authored-by: dankrad <mail@dankradfeist.de> * minor nits in proving.mdx (#54) * Update src/pages/learn/tempo/privacy.mdx Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @dankrad * Apply suggestion from @dankrad * Apply suggestion from @dankrad * Apply suggestion from @malleshpai Co-authored-by: malleshpai <mallesh.pai@gmail.com> * Apply suggestion from @dankrad * Apply suggestion from @danrobinson Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @danrobinson Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @danrobinson Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @dankrad * Apply suggestion from @danrobinson Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @dankrad * Apply suggestion from @dankrad * Apply suggestion from @dankrad * Restructure Tempo Zones docs: new IA, terminology fixes (#56) * Restructure Tempo Zones documentation Split the zones overview into a proper information architecture: - New overview page with key properties and spec navigation cards - Architecture page (extracted from old overview, structural content) - Accounts page (extracted from old privacy, EVM-level access control) - Execution & Gas page (consolidated from overview + privacy) - Remove standalone privacy page (content split into accounts + overview) Terminology changes across all zone pages: - 'L1'/'L2' replaced with 'Tempo Mainnet' throughout - 'Zones' replaced with 'Tempo Zones' in prose - Em dashes replaced with commas and periods - Sidebar label changed from 'Zones' to 'Tempo Zones' - Specification pages grouped under a 'Specification' sidebar header Adds 301 redirects for /protocol/zones/overview and /protocol/zones/privacy. Amp-Thread-ID: https://ampcode.com/threads/T-019d4538-30c7-74ad-b74c-efcb7249e5fe Co-authored-by: Amp <amp@ampcode.com> * Apply review suggestions from base branch - non-custodial → safe from theft - EVM level → contract level - Remove 'Both layers are required' (redundant with next sentence) - Add 'for TIP-20s' to balanceOf restriction - Remove sentence about synchronous L1 state reads from architecture intro - Sequencer management 'is centralized' → 'happens' - 'opt-in privacy' → 'privacy' - Authorization token max 30 minutes → 1 month - Update replay protection fields (remove portal address, add zone 0 wildcard) - 'Zones disable' → 'Zones currently disable' CREATE opcodes Amp-Thread-ID: https://ampcode.com/threads/T-019d492e-f36b-721a-99bd-57b64f8a6e03 Co-authored-by: Amp <amp@ampcode.com> --------- Co-authored-by: Amp <amp@ampcode.com> * docs: remove spec-only sections from zones docs Remove Deposit Queue, Withdrawal Queue, and Queue Design sections from bridging.mdx. Remove entire upgrades.mdx page and its sidebar entry. These belong in the formal specs, not user-facing docs. Co-authored-by: dankrad <6130607+dankrad@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4a8c-806c-7245-9d32-9ee4a96b2ae3 * docs: rename zones sidebar section from Specification to Reference Co-authored-by: dankrad <6130607+dankrad@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4a8c-806c-7245-9d32-9ee4a96b2ae3 * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestion from @dankrad * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestion from @dankrad * docs: remove dead link to upgrades page Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d63e4-5fa8-766b-bdd9-05ad92044c04 * docs: remove 'withdraw at any time' claims Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d63e4-5fa8-766b-bdd9-05ad92044c04 * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> --------- Co-authored-by: malleshpai <mallesh.pai@gmail.com> Co-authored-by: dankrad <mail@dankradfeist.de> Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: dankrad <6130607+dankrad@users.noreply.github.com>
Zygimantass
added a commit
that referenced
this pull request
Apr 16, 2026
* docs: add Zones protocol documentation (#49) * docs: add Zones protocol documentation Add comprehensive documentation for the Tempo Zones feature: - Overview: architecture, zone creation, token management, fees - Bridging: deposits, withdrawals, encrypted deposits, composable callbacks - Privacy Zones: execution-level and RPC-level privacy protections - Proving: batch submission, verifier interface, ancestry proofs - Upgrades: hard fork activation, verifier rotation, failure modes Also updates the privacy learn page to reference Zones and adds a Zones card to the protocol index. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): rework overview with intro from design doc Incorporate the high-level intro, system architecture diagrams, contract architecture, trust model table, and creating a zone walkthrough from the zones design document. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * fix: escape angle bracket in MDX to fix build Replace '<10 seconds' with 'under 10 seconds' — the bare '<' was parsed as a JSX tag by the MDX compiler. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): convert ASCII art to mermaid diagrams Replace ASCII art illustrations with native mermaid code blocks, matching the pattern used in validator-config-v1.mdx and validator-config-v2.mdx. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): add note that prover is not yet live Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): clarify withdrawal queue slots contain multiple withdrawals Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * fix(zones): fix mermaid diagram rendering - Replace \n with <br/> for multi-line node labels (mermaid requires HTML) - Reorder edge definitions before subgraphs to fix withdrawal arrow routing through ZoneFactory instead of ZonePortal - Remove redundant edge labels for cleaner system architecture diagram Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): remove queue design rationale paragraph Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): rewrite privacy page, split RPC into own page All zones are private by design — rewrite the privacy page to reflect this rather than treating privacy as a special variant. Move the RPC specification (auth tokens, method access control, timing side channels, event filtering, error codes) into a dedicated /protocol/zones/rpc page. Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): remove incorrect contract creation rationale Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): wording fix in proving page Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): wording fix for ancestry proofs Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * docs(zones): note encrypted deposits exception for quantum security Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d2a83-5a87-708e-b2cd-8aca731e0ae6 * Refine overview.mdx (#52) * Refine overview.mdx - consistent terminology (zone vs tempo L1, as opposed to chain, main chain etc). - minor nits/ rewording * Apply suggestion from @dankrad * Apply suggestion from @dankrad --------- Co-authored-by: dankrad <mail@dankradfeist.de> * Update privacy.md for clarity and terminology (#53) * Update privacy.md for clarity and terminology * Apply suggestion from @dankrad --------- Co-authored-by: dankrad <mail@dankradfeist.de> * minor nits in proving.mdx (#54) * Update src/pages/learn/tempo/privacy.mdx Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @dankrad * Apply suggestion from @dankrad * Apply suggestion from @dankrad * Apply suggestion from @malleshpai Co-authored-by: malleshpai <mallesh.pai@gmail.com> * Apply suggestion from @dankrad * Apply suggestion from @danrobinson Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @danrobinson Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @danrobinson Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @dankrad * Apply suggestion from @danrobinson Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> * Apply suggestion from @dankrad * Apply suggestion from @dankrad * Apply suggestion from @dankrad * Restructure Tempo Zones docs: new IA, terminology fixes (#56) * Restructure Tempo Zones documentation Split the zones overview into a proper information architecture: - New overview page with key properties and spec navigation cards - Architecture page (extracted from old overview, structural content) - Accounts page (extracted from old privacy, EVM-level access control) - Execution & Gas page (consolidated from overview + privacy) - Remove standalone privacy page (content split into accounts + overview) Terminology changes across all zone pages: - 'L1'/'L2' replaced with 'Tempo Mainnet' throughout - 'Zones' replaced with 'Tempo Zones' in prose - Em dashes replaced with commas and periods - Sidebar label changed from 'Zones' to 'Tempo Zones' - Specification pages grouped under a 'Specification' sidebar header Adds 301 redirects for /protocol/zones/overview and /protocol/zones/privacy. Amp-Thread-ID: https://ampcode.com/threads/T-019d4538-30c7-74ad-b74c-efcb7249e5fe Co-authored-by: Amp <amp@ampcode.com> * Apply review suggestions from base branch - non-custodial → safe from theft - EVM level → contract level - Remove 'Both layers are required' (redundant with next sentence) - Add 'for TIP-20s' to balanceOf restriction - Remove sentence about synchronous L1 state reads from architecture intro - Sequencer management 'is centralized' → 'happens' - 'opt-in privacy' → 'privacy' - Authorization token max 30 minutes → 1 month - Update replay protection fields (remove portal address, add zone 0 wildcard) - 'Zones disable' → 'Zones currently disable' CREATE opcodes Amp-Thread-ID: https://ampcode.com/threads/T-019d492e-f36b-721a-99bd-57b64f8a6e03 Co-authored-by: Amp <amp@ampcode.com> --------- Co-authored-by: Amp <amp@ampcode.com> * docs: remove spec-only sections from zones docs Remove Deposit Queue, Withdrawal Queue, and Queue Design sections from bridging.mdx. Remove entire upgrades.mdx page and its sidebar entry. These belong in the formal specs, not user-facing docs. Co-authored-by: dankrad <6130607+dankrad@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4a8c-806c-7245-9d32-9ee4a96b2ae3 * docs: rename zones sidebar section from Specification to Reference Co-authored-by: dankrad <6130607+dankrad@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4a8c-806c-7245-9d32-9ee4a96b2ae3 * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestion from @dankrad * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> * Apply suggestion from @dankrad * docs: remove dead link to upgrades page Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d63e4-5fa8-766b-bdd9-05ad92044c04 * docs: remove 'withdraw at any time' claims Prompted by: dankrad Amp-Thread-ID: https://ampcode.com/threads/T-019d63e4-5fa8-766b-bdd9-05ad92044c04 * Apply suggestions from code review Co-authored-by: dankrad <mail@dankradfeist.de> --------- Co-authored-by: malleshpai <mallesh.pai@gmail.com> Co-authored-by: dankrad <mail@dankradfeist.de> Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: dankrad <6130607+dankrad@users.noreply.github.com> * feat: add zone demos (#59) * feat: add zone demos * feat: add private zone verification flows Amp-Thread-ID: https://ampcode.com/threads/T-019d4ec2-4960-75dd-81a1-67ebed584a50 Co-authored-by: Amp <amp@ampcode.com> * fix: polish * feat: encryption and other fixes * fix: polish * fix: make steps sticky until restart * fix: build * fix: passkeys * fix: remove stage info * fix: polish * fix: json --------- Co-authored-by: Amp <amp@ampcode.com> * fix: types * chore: add banner * fix: refactor with latest viem * feat: add send across zones * feat: reuse auth token * fix: suppress spurious zone auth error Amp-Thread-ID: https://ampcode.com/threads/T-019d70b3-ae75-70de-bfc1-cdcdc45deafb Co-authored-by: Amp <amp@ampcode.com> * fix: widen zone settlement detection Amp-Thread-ID: https://ampcode.com/threads/T-019d70b3-ae75-70de-bfc1-cdcdc45deafb Co-authored-by: Amp <amp@ampcode.com> * fix: stop linking zone receipts to explorer Amp-Thread-ID: https://ampcode.com/threads/T-019d70b3-ae75-70de-bfc1-cdcdc45deafb Co-authored-by: Amp <amp@ampcode.com> * docs: reorder zones security sections Improve the zones overview flow by grouping the theft-safety explanation after the compliance guarantees. Made-with: Cursor * docs: merge zone RPC method tables Simplify the zone RPC access control docs by combining allowed and scoped methods into a single table with explicit access types. Made-with: Cursor * docs: add zone execution flow diagram Clarify the execution and gas model by adding a Mermaid diagram that shows validation, gas selection, execution, and fee settlement. Made-with: Cursor * feat: add StaticMermaidDiagram component for consistent diagram styling (#62) * feat: add StaticMermaidDiagram component for consistent diagram styling - New StaticMermaidDiagram component that uses the mermaid library with theme colors from the existing MermaidDiagram component - Uses site's system sans-serif font instead of monospace - Compact node spacing and padding matching the docs design - Supports dark/light mode via THEMES from MermaidDiagram - Replaces raw mermaid code blocks in architecture.mdx and execution.mdx * fix: improve dark mode contrast for StaticMermaidDiagram - Lighter node backgrounds (#2e2e33) so they stand out from page bg - Stronger borders (#52525b) for both nodes and clusters - Darker cluster background (#1e1e22) for depth separation * docs: move execution flow diagram to proving Correct the zone docs by placing the execution flow diagram on the proving page and removing it from the execution page. Made-with: Cursor * feat: add connect-to-a-zone page * fix: bump viem * fix: withdraws * docs: add zone architecture diagrams with descriptive names (#61) * docs: add static zone architecture diagrams Place 7 SVG diagrams across the zones guide and protocol pages. * fix: add HB Set + Pilat fonts for SVG rendering, fix diagram placement - Add woff2 font files (HB Set v0.96 Light/Medium, Pilat Regular/Demi/Bold) to public/fonts/ with @font-face declarations in _root.css so SVG text renders correctly on Vercel (not just macOS) - Move diagram-f (Privacy Flow) from guide/private-zones/index to protocol/zones/index under "Tempo Zones are private" where it fits the surrounding copy better * docs: add diagram-h to zones overview after intro paragraph * docs: add diagram-b under deposit two-phase settlement * docs: move diagram-b above ZonePortal intro paragraph * docs: add diagram-b to withdrawals page * fix: embed fonts directly in SVGs so they render in img tags on Vercel * docs: add diagram-e to token management, diagram-f to bridging overview * Update index.mdx * refactor: replace lettered diagrams with named SVGs, remove font deps - Replace diagram-a..h with descriptive names (diagram-node, diagram-deposit, diagram-overview, diagram-privacy, diagram-swap, diagram-tip20, diagram-withdraw) - New SVGs use outlined text (no font embedding needed) - Remove @font-face imports from _root.css and woff2 files from public/fonts/ - Remove diagram-d from send-across-zones (no named equivalent) - Use diagram-withdraw on withdraw page instead of diagram-deposit * docs: add diagram-overview to Connect to Tempo Zones guide * docs: use diagram-contracts under Contract Architecture * fix: update wording --------- Co-authored-by: Zygimantas <5236121+Zygimantass@users.noreply.github.com> Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com> * fix: zone renamings * feat: cleanup * fix: rebase * fix: unblock CI for custom viem build * fix: deps * fix: correctness --------- Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com> Co-authored-by: malleshpai <mallesh.pai@gmail.com> Co-authored-by: dankrad <mail@dankradfeist.de> Co-authored-by: Daniel Robinson <danrobinson010@gmail.com> Co-authored-by: Liam Horne <liam@lihorne.com> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: dankrad <6130607+dankrad@users.noreply.github.com> Co-authored-by: Brendan Ryan <brendanjryan@users.noreply.github.com> Co-authored-by: achalvs <achal@achal.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes tempoxyz/tempo#2304