fix: prevent busy loop in default wait_for_update impl#194
Merged
brendanjryan merged 2 commits intotempoxyz:mainfrom Apr 7, 2026
Merged
fix: prevent busy loop in default wait_for_update impl#194brendanjryan merged 2 commits intotempoxyz:mainfrom
wait_for_update impl#194brendanjryan merged 2 commits intotempoxyz:mainfrom
Conversation
evchip
requested review from
Slokh,
brendanjryan,
mattsse and
onbjerg
as code owners
Collaborator
|
LGTM -- thanks for the submission! Can you add a changelog entry? |
Contributor
Author
Added it under a 0.8.5 patch release. Let me know if you'd like it written a different way @brendanjryan |
evchip
force-pushed
the
fix/default-wait-for-update-busy-loop
branch
from
9039836 to
b3fd45c
Compare
Contributor
Author
|
Rebased on main and replaced the |
brendanjryan
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
wait_for_update()onChannelStorereturns immediately (Box::pin(async {})), which causes thetokio::select!inserve()to never hit the sleep branch, resulting in a busy loop instead of 100ms polling.This PR fixes this by changing the default to
std::future::pending(), which never completes, so the sleep branch always wins theselect!.Closes issue #193