docs: align service contribution guidance and contributor checklist#453
docs: align service contribution guidance and contributor checklist#453brendanjryan merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a69b95573
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
scripts/check-install-tabs.test.ts
Outdated
| for (let i = 0; i < lines.length; i++) { | ||
| // Look for a bash [npm] block that contains an install command | ||
| const line = lines[i]; | ||
| if (!/^```bash \[npm\]/.test(line)) continue; |
There was a problem hiding this comment.
This test only starts validation when it sees ````bash [npm]```, so an install code-group that has pnpm/`bun` tabs but omits `npm` is never checked and will pass CI even though it violates the new rule requiring all three tabs. In practice, reordering tabs or authoring a pnpm-first install block bypasses the guard entirely.
Useful? React with 👍 / 👎.
brendanjryan
force-pushed
the
docs/add-bun-install-tabs
branch
from
a801f8c to
6a677de
Compare
1 participant
Summary
mpp.dev/servicesPR criteria explicitValidation
pnpm check:typespnpm build(fails in current tree due to unresolved@resvg/resvg-wasmimport fromsrc/pages/_api/api/og.tsx, unrelated to these doc/workflow edits)