chore: untrack generated discovery artifacts#459
Conversation
These files were added to .gitignore in #433 but never removed from git tracking. Running git rm --cached so the gitignore actually takes effect and PRs stop getting conflicts on generated files.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5916b67ba7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,11989 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Removing schemas/discovery.json breaks the endpoint/metadata diff logic in .github/workflows/changed-services.yml: fileAt(..., 'schemas/discovery.json') now returns null for base/head, so parseDiscovery yields empty maps and the baseSvc && headSvc branch (lines 111–118) never runs. In that state, PRs that modify existing services in schemas/services.ts (for example endpoint pricing, descriptions, or paths) are reported as “No service-level changes detected,” which regresses review visibility for service updates.
Useful? React with 👍 / 👎.
1 participant
Problem
PR #433 added
schemas/discovery.json,schemas/discovery.example.json, andpublic/services/llms.txtto.gitignore— but never rangit rm --cachedto actually untrack them. Git ignores.gitignorefor files already in the index, so PRs (like #458) keep editing and conflicting on these generated files.Fix
git rm --cachedthe three files so the.gitignoreentries take effect. The files remain on disk (generated bypnpm generate:discovery) but are no longer committed.