Remove redundant isFlipOrder from OrderFlipped event#106
Merged
Conversation
The OrderFlipped event is only emitted for flip orders, so isFlipOrder is always true and redundant. Removing it per review feedback on tempoxyz/tempo#3776. Amp-Thread-ID: https://ampcode.com/threads/T-019e0833-6b25-7549-905a-1968e181937d
decofe
requested review from
0xrusowsky,
grandizzy,
onbjerg and
zerosnacks
as code owners
0xKitsune
approved these changes
May 8, 2026
zerosnacks
approved these changes
May 8, 2026
zerosnacks
left a comment
zerosnacks
left a comment
Contributor
There was a problem hiding this comment.
Lgtm, only note I would make is that indexers that go to genesis will need to account for this field changing.
klkvr
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OrderFlippedevent is only emitted for flip orders, soisFlipOrderis alwaystrueand redundant.Removing per review feedback on tempoxyz/tempo#3776 (comment).