Skip to content

feat(consensus): encrypt signing keys at rest#4111

Merged
SuperFluffy merged 7 commits into
mainfrom
janis/encrypt-signing-key
May 27, 2026
Merged

feat(consensus): encrypt signing keys at rest#4111
SuperFluffy merged 7 commits into
mainfrom
janis/encrypt-signing-key

Conversation

@SuperFluffy
Copy link
Copy Markdown
Contributor

@SuperFluffy SuperFluffy commented May 20, 2026

Adds passphrase-encrypted consensus signing-key support and pipe-based passphrase loading for node startup and CLI key utilities.

New and updated CLI:

# Encrypt existing signing keys
tempo consensus encrypt-signing-key --input <FILE> --output <FILE> --secret <PIPE> [--force]

# New optional --secret <PIPE> arg to generate new signing keys with encryption
# Maintains old alias generate-public-key
tempo consensus generate-signing-key --output <FILE> [--secret <PIPE>] [--force]

# New optional --secret <PIPE> to show the verification key for encrypted signing keys
# Maintains old alias calculate-public-key
tempo consensus show-verification-key --private-key <FILE> [--secret <PIPE>]

# New optional --secret <PIPE> to decrypt encrypted signing keys at startup
tempo node --consensus.signing-key <FILE> [--consensus.secret <PIPE>]

The argument --secret <PIPE> accepts all Paths, but FIFOs (named pipes) and shell process substitution paths such as <(...) are preferred.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 20, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedage@​0.11.310010093100100
Addedsecrecy@​0.10.310010093100100

View full report

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented May 20, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing janis/encrypt-signing-key (6a885af) with main (adb349f)

Open in CodSpeed

@SuperFluffy SuperFluffy marked this pull request as ready for review May 22, 2026 13:08
Copy link
Copy Markdown
Contributor

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about fifo. Pretty cool

@SuperFluffy SuperFluffy added this pull request to the merge queue May 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 27, 2026
@SuperFluffy SuperFluffy added this pull request to the merge queue May 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 27, 2026
@SuperFluffy SuperFluffy enabled auto-merge May 27, 2026 15:08
@SuperFluffy SuperFluffy added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit d289303 May 27, 2026
40 checks passed
@SuperFluffy SuperFluffy deleted the janis/encrypt-signing-key branch May 27, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants