Merged
Conversation
- write_blocks: replace manual BEGIN/COMMIT with conn.transaction() - write_txs/write_logs/write_receipts: wrap DELETE+COPY in a transaction - SET statement_timeout -> SET LOCAL (scoped to transaction, not connection) Prevents pool poisoning on error/cancellation and makes DELETE+COPY atomic. Co-Authored-By: Kamil Szczygieł <2961450+kamsz@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d0c20-7f67-770d-9b18-050510968357
decofe
force-pushed
the
kamil/blocks-copy-binary
branch
from
97d6f31 to
d8040cd
Compare
o-az
pushed a commit
that referenced
this pull request
Apr 27, 2026
- write_blocks: replace manual BEGIN/COMMIT with conn.transaction() - write_txs/write_logs/write_receipts: wrap DELETE+COPY in a transaction - SET statement_timeout -> SET LOCAL (scoped to transaction, not connection) Prevents pool poisoning on error/cancellation and makes DELETE+COPY atomic. Amp-Thread-ID: https://ampcode.com/threads/T-019d0c20-7f67-770d-9b18-050510968357 Co-authored-by: Kamil Szczygieł <2961450+kamsz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces dynamic multi-row INSERT with
VALUES ($1...$N*9)with COPY BINARY via a staging temp table._staging_blockstemp table (dropped on commit)INSERT INTO blocks SELECT * FROM _staging_blocks ON CONFLICT (timestamp, num) DO NOTHINGstd::fmt::Writeimport (no longer needed)Gives PG a stable execution plan and avoids O(N) query string formatting. Consistent with
write_txs/write_logs/write_receipts.Prompted by: kamil