fix: seed ClickHouse metrics + show gaps in status#98
Merged
Conversation
- Add seed_metrics_from_clickhouse() to populate in-memory watermarks and row counts from ClickHouse on startup (max block + count per table) - Add ClickHouseSink::row_count() helper - Fix ETA display: use gap_blocks instead of synced_num (which is 0 during gap-fill) so ETA appears during backfill - Show gap_blocks remaining in status display Amp-Thread-ID: https://ampcode.com/threads/T-019c930c-df99-724a-a41b-65c98b607256 Co-authored-by: Amp <amp@ampcode.com>
Shows gaps beside the blocks progress line for each store, e.g.: blocks 493,790 / 6,230,479 (7%) (2 gaps) Also fixes blocks progress to use the store's own watermark instead of synced_num (which is 0 during gap-fill). Amp-Thread-ID: https://ampcode.com/threads/T-019c930c-df99-724a-a41b-65c98b607256 Co-authored-by: Amp <amp@ampcode.com>
o-az
pushed a commit
that referenced
this pull request
Apr 27, 2026
* fix: seed ClickHouse metrics on startup + use gap_blocks for ETA - Add seed_metrics_from_clickhouse() to populate in-memory watermarks and row counts from ClickHouse on startup (max block + count per table) - Add ClickHouseSink::row_count() helper - Fix ETA display: use gap_blocks instead of synced_num (which is 0 during gap-fill) so ETA appears during backfill - Show gap_blocks remaining in status display Amp-Thread-ID: https://ampcode.com/threads/T-019c930c-df99-724a-a41b-65c98b607256 Co-authored-by: Amp <amp@ampcode.com> * feat: show gap count inline on blocks row in status display Shows gaps beside the blocks progress line for each store, e.g.: blocks 493,790 / 6,230,479 (7%) (2 gaps) Also fixes blocks progress to use the store's own watermark instead of synced_num (which is 0 during gap-fill). Amp-Thread-ID: https://ampcode.com/threads/T-019c930c-df99-724a-a41b-65c98b607256 Co-authored-by: Amp <amp@ampcode.com> --------- Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for the status display:
1. Seed ClickHouse metrics on startup
ClickHouse row counts and watermarks were showing only writes since last restart. Now
seed_metrics_from_clickhouse()queriesmax(block_num)andcount()per table on startup.ClickHouseSink::row_count()helper2. Show gaps inline + fix ETA/progress
synced_num(which is 0 during gap-fill)blocks 493,790 / 6,230,479 (7%) (2 gaps)gap_blocksinstead ofsynced_numso it appears during backfillsync_ratevaluesChanges
src/cli/up.rs:seed_metrics_from_clickhouse()src/cli/status.rs: gap display, ETA fix, use store watermark for blocks progresssrc/sync/ch_sink.rs:row_count()method