docs(spec): add missing event definitions to contract interfaces#393
Merged
docs(spec): add missing event definitions to contract interfaces#393
Conversation
Co-Authored-By: 0xKitsune <77890308+0xKitsune@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d9300-8bb9-76b9-a881-ce8cef9d6080
0xKitsune
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Contracts and Interfaces section of
zone_spec.mdonly had events forIZoneFactory. All other interfaces were missing their event definitions despite the events being referenced in the spec prose and defined in the Solidity source (IZone.sol).Changes
DepositMade,EncryptedDepositMade,BatchSubmitted,WithdrawalProcessed,BounceBack,SequencerTransferStarted,SequencerTransferred,SequencerEncryptionKeyUpdated,ZoneGasRateUpdated,TokenEnabled,DepositsPaused,DepositsResumed)TempoBlockFinalizedTempoAdvanced,DepositProcessed,EncryptedDepositProcessed,EncryptedDepositFailed,TokenEnabled)WithdrawalRequested,TempoGasRateUpdated,MaxWithdrawalsPerBlockUpdated,BatchFinalized)All signatures match the implementation in
docs/specs/src/zone/IZone.sol.Co-Authored-By: 0xKitsune 77890308+0xKitsune@users.noreply.github.com
Prompted by: daniel