This repository was archived by the owner on Feb 23, 2022. It is now read-only.
RFC-001: configurable block retention #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
requested review from
josef-widder,
konnov and
milosevic
as code owners
This was referenced Mar 23, 2020
melekes
approved these changes
Mar 24, 2020
Contributor
melekes
left a comment
melekes
left a comment
There was a problem hiding this comment.
LGTM
I'd vote for adding explicit checks to Cosmos SDK to prevent misconfiguration.
…some minor tweaks
Contributor
Author
I've added some enforced checks and made a few other changes. Will give others a chance to review as well. |
Contributor
Author
|
@alexanderbez @ebuchman @brapse Do you have any opinions on this? |
4 tasks
zmanian
reviewed
Mar 26, 2020
tac0turtle
reviewed
Mar 26, 2020
erikgrinaker
changed the title
melekes
reviewed
Apr 1, 2020
melekes
approved these changes
Apr 2, 2020
erikgrinaker
changed the title
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: https://github.com/tendermint/spec/blob/master/rfc/001-block-retention.md