Validity checks #2796
Closed
Validity checks #2796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2018 12:51
zmanian
requested review from
ebuchman,
melekes,
xla and
zramsay
as code owners
ValarDragon
reviewed
Nov 9, 2018
| }{ | ||
| {"127.0.0.1:8080", true, true, false}, | ||
| {"ya.ru:80", true, false, true}, | ||
| {"123fdc2a9bce5f2ef01e907a1d6a16548ee5a245@ya.ru:80", true, false, true}, |
There was a problem hiding this comment.
Can you add these as new vectors, instead of removing the old vector? (Unless the old test didn't make sense for some reason)
alexanderbez
reviewed
Nov 9, 2018
p2p/netaddress.go
Outdated
| // For IPv4 these are either a 0 or all bits set address. For IPv6 a zero | ||
| // address or one that matches the RFC3849 documentation address format. | ||
| func (na *NetAddress) Valid() bool { | ||
| if na.Local() == false { |
There was a problem hiding this comment.
Suggested change
| if na.Local() == false { | |
| if !na.Local() { |
Codecov Report
@@ Coverage Diff @@
## develop #2796 +/- ##
===========================================
+ Coverage 62.3% 62.38% +0.08%
===========================================
Files 212 212
Lines 17210 17215 +5
===========================================
+ Hits 10722 10739 +17
+ Misses 5588 5577 -11
+ Partials 900 899 -1
|
Co-Authored-By: zmanian <zaki@manian.org>
Co-Authored-By: zmanian <zaki@manian.org>
|
See: #2797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is one a approach to the peers without IDs in the address book.