-
Couldn't load subscription status.
- Fork 137
support mdbx backend #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support mdbx backend #297
Conversation
|
Sir, I will review and test, no matter tm-db total lack of matienance. I had no idea how to implement. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tendermint should use a single kv db and get rid of the rest or migrate to sqldb. Adding dbs without proper testing and optimisation for the use case is adding more noise.
I was actually trying this backend with cosmos-sdk, the iavl tree store, agree that rdbms maybe a good fit for tendermint store. |
|
Will try to add this to cosmos-db instead. This PR: and /or this one: should help, I thought they were great ideas. |
|
not sure how sdk store package PR helps this PR? could you elaborate? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I added this backend to run some benchmarks, to see how mdbx performs.
Based on the simple local benchmarks, compared with rocksdb, the db size is larger, insert speed is slower. maybe interesting to try on a production node.
One feature that would be very useful is the db can be opened by multi-processes, so one can inspect the db of a live node.