Skip to content

Conversation

@yihuang
Copy link

@yihuang yihuang commented Sep 29, 2022

I added this backend to run some benchmarks, to see how mdbx performs.
Based on the simple local benchmarks, compared with rocksdb, the db size is larger, insert speed is slower. maybe interesting to try on a production node.

  • The batch might can be implemented more efficiently using the transaction, if we only use one batch at the same time.
  • It don't use the other features like dupsort.

One feature that would be very useful is the db can be opened by multi-processes, so one can inspect the db of a live node.

@yihuang yihuang marked this pull request as ready for review October 6, 2022 02:36
@faddat
Copy link
Contributor

faddat commented Nov 8, 2022

Sir, I will review and test, no matter tm-db total lack of matienance.

I had no idea how to implement. thanks!

Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tendermint should use a single kv db and get rid of the rest or migrate to sqldb. Adding dbs without proper testing and optimisation for the use case is adding more noise.

@yihuang
Copy link
Author

yihuang commented Nov 9, 2022

tendermint should use a single kv db and get rid of the rest or migrate to sqldb. Adding dbs without proper testing and optimisation for the use case is adding more noise.

I was actually trying this backend with cosmos-sdk, the iavl tree store, agree that rdbms maybe a good fit for tendermint store.
Since cosmos-sdk is migrating to another db repo, maybe we leave it as an experimental thing, no need to merge.

@yihuang yihuang marked this pull request as draft November 9, 2022 00:57
@faddat
Copy link
Contributor

faddat commented Nov 22, 2022

Will try to add this to cosmos-db instead.

This PR:

cosmos/cosmos-sdk#13966

and /or this one:

cosmos/cosmos-sdk#13931

should help, I thought they were great ideas.

@faddat
Copy link
Contributor

faddat commented Nov 22, 2022

@tac0turtle
Copy link
Contributor

not sure how sdk store package PR helps this PR? could you elaborate?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Dec 13, 2022
@github-actions github-actions bot closed this Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants