C25c: CLI dogfood quick wins (B1+B2+B4)#1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles the three CLI-side findings from the B-audit. Each is independently small; ships as one PR for review efficiency (matches the S62 envelope-batch pattern).
pr mergesuccess line acceptsmerge_commit_sha.MergeResultnow decodes both the gh-compat field and the legacysha. New accessorCommitSHA()prefers gh-compat. Without this the success line was rendering ("Merged PR #N at ") with an empty SHA on shithub builds that emit onlymerge_commit_sha.--jsonfield gh-compat aliases.repo view/repo listexport catalogs exposeforkCount,stargazerCount,watcherCountalongside the legacyforks/stargazers/watchers. Ported gh scripts (gh repo view --json stargazerCount) work verbatim. Both names populated for one release cycle.repo forkfriendlier own-repo error. Pre-flight check resolves the authenticated user (cached) and refuses with a clear message naming the repo before round-tripping.--orgbypasses the guard (forking your own repo into a different org is a real workflow).Test plan
TestMergeCommitSHA_GhCompat— decoder acceptsmerge_commit_sha.TestMergeCommitSHA_PrefersGhCompat— gh-compat wins on both-fields-set.TestViewJSONGhCompatAliases—--json stargazerCount,forkCount,watcherCountprojects numeric values.TestForkRejectsOwnRepo— clear pre-flight error; forks endpoint never hit.TestForkOwnRepoIntoOrgAllowed—--orgbypass.make cigreen locally.