rules: add genericity, best-practice, and self-review rules#10
Merged
rules: add genericity, best-practice, and self-review rules#10
Conversation
- common-agent-rules.md: add KISS, DRY, Single Source of Truth, Abstraction, Layering, Separation of Concerns, fix-root-causes, and no-speculative-backward-compatibility as core principles; consolidate duplicate Design Principles section - numerical-rust-rules.md: add Backend and Scalar Type Genericity section covering TypeId dispatch, hardcoded backends, scalar conversion naming, and macro-based deduplication; add Generic Test Patterns section; remove duplication with common rules - createpr.md: add self-review step against rule files before PR Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai/common-agent-rules.mdas core principlesBackend and Scalar Type GenericityandGeneric Test Patternsguidance toai/numerical-rust-rules.mdAGENTS.mdso the repo-local entrypoint stays aligned with shared rulesTest plan
cargo fmt --all --checkcargo clippy --workspacecargo test --release --workspacecargo llvm-cov --workspace --release --json --output-path coverage.jsonpython3 scripts/check-coverage.py coverage.jsoncargo doc --workspace --no-depspython3 scripts/check-docs-site.pyGenerated with Codex