Fix Windows Nightly #2225
Merged
Fix Windows Nightly #2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhack
approved these changes
Nov 2, 2020
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Set nightly flag in bash shell for all OS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2222 . Recently the default shell for windows must have changed to PowerShell and the nightly flag env was not propagating to the build step:
https://github.com/tensorflow/addons/pull/2225/checks?check_run_id=1339434783
This debug run with shell explicitly set shows that this fixes the problem:
https://github.com/tensorflow/addons/pull/2225/checks?check_run_id=1339447511