Skip to content

FIX MacOS Build #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facaiy merged 7 commits into from
Aug 28, 2019
Merged

FIX MacOS Build #452

facaiy merged 7 commits into from
Aug 28, 2019

Conversation

@seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented Aug 27, 2019 •
edited
Loading

  • Reorganize toolchain directory
  • Remove windows toolchains for time being
  • Update releases scripts to include CPU optimizations

Closes #448

@seanpmorgan
* Reorganize toolchain directory
ff9cd83 
* Remove windows toolchains for time being
* Update releases scripts to include CPU optimizations
@seanpmorgan seanpmorgan requested a review from a team as a code owner August 27, 2019 14:15
@seanpmorgan seanpmorgan changed the title FIX MacOS Build [WIP] FIX MacOS Build Aug 27, 2019
@seanpmorgan seanpmorgan changed the title [WIP] FIX MacOS Build FIX MacOS Build Aug 27, 2019
@seanpmorgan
Copy link
Member Author

seanpmorgan commented Aug 27, 2019

Build is successful:
https://travis-ci.org/seanpmorgan/addons/builds/577431861

facaiy
facaiy approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@facaiy facaiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sean.

@facaiy
Copy link
Member

facaiy commented Aug 28, 2019

tensorflow pip package has included GPU supports by default since a few days ago, does the change break our build?

@facaiy facaiy merged commit 0811550 into tensorflow:master Aug 28, 2019
@seanpmorgan seanpmorgan deleted the fix-macos-build branch August 28, 2019 01:48
@seanpmorgan
Copy link
Member Author

seanpmorgan commented Aug 28, 2019

tensorflow pip package has included GPU supports by default since a few days ago, does the change break our build?

Hmmm I think tf-nightly does but tf-nightly-2.0-preview does not? (Think thats slated for 2.1):
https://colab.research.google.com/drive/1QSKCZSpUCSgrAxvev8HKjgybVrNn_gNK

The nightly build succeeded in any case. Next thing I plan to work on is #449 which if all goes well will load CUDA kernels for tf-nightly-gpu-2.0-preview and default to CPU for tf-nightly-2.0-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facaiy facaiy facaiy approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix build for MacOS

4 participants

@seanpmorgan @facaiy @googlebot @kokoro-team