Skip to content

fixes bugs when using fit generator #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seanpmorgan merged 1 commit into from
Jan 4, 2020
Merged

fixes bugs when using fit generator #829

seanpmorgan merged 1 commit into from
Jan 4, 2020

Conversation

@shun-lin
Copy link
Contributor

@shun-lin shun-lin commented Jan 3, 2020 •
edited
Loading

Quick fix to a bug when using fit_generator
It turns out that when using fit_generator the progress bar is updating by 1 (instead of by batch_size) after each batch, but we still need to keep the number of samples seen to accuracy compute and display the metrics. Therefore I add another field to keep track of steps so far and rename self.seen to self.num_samples_seen for clarity.

Edit: Link to Issue
#812

@shun-lin shun-lin requested a review from Squadrick as a code owner January 3, 2020 19:15
seanpmorgan
seanpmorgan approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!

@seanpmorgan seanpmorgan merged commit 3dd560c into tensorflow:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@Squadrick Squadrick Awaiting requested review from Squadrick

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shun-lin @seanpmorgan @googlebot