-
Notifications
You must be signed in to change notification settings - Fork 618
DOC: use logo for SIG/addons #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
seanpmorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like it a lot, but IMO its a little too large? Can we re-size in HTML on github markdown?
e.g. <img src="logo.jpg" width="200" height="100"> or some size that makes sense?
0ae54ac to
01fd853
Compare
|
Totally agreed. How about the new one? Dose it look better? |
01fd853 to
b399b3b
Compare
b399b3b to
e250949
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
@facaiy I clipped some of the whitespace around the text and uploaded a local file so we don't need to worry about the link. If you like the image better, should we merge it into community or is the static file in repo okay? |
|
I prefer public url to static file in the repo, but both are fine. And I'm afraid svg format cannot play well with markdown, while png format perhaps is better for web :-) |
|
Sean, I'd like to leave it up to you :-) |
|
So I think we'll meet somewhere in the middle. I do think SVG is preferred format for web, but to be fair that wasn't a true svg graphic, just an image imported into svg. I'm uncomfortable with the URL link as it's outside of our control and could be broken without our knowledge. So PNG in repo I think is a good middle ground. I could live with the URL link, but I think it needs to be cropped anyway. |
* DOC: use logo for SIG/addons
Thank @ewilderj :-)