Skip to content

Conversation

@facaiy
Copy link
Member

@facaiy facaiy commented Mar 15, 2019

Thank @ewilderj :-)

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it a lot, but IMO its a little too large? Can we re-size in HTML on github markdown?
e.g. <img src="logo.jpg" width="200" height="100"> or some size that makes sense?

@facaiy facaiy force-pushed the DOC/add_addons_logo branch from 0ae54ac to 01fd853 Compare March 15, 2019 14:54
@facaiy
Copy link
Member Author

facaiy commented Mar 15, 2019

Totally agreed. How about the new one? Dose it look better?

@facaiy facaiy force-pushed the DOC/add_addons_logo branch from 01fd853 to b399b3b Compare March 15, 2019 15:01
@facaiy facaiy force-pushed the DOC/add_addons_logo branch from b399b3b to e250949 Compare March 15, 2019 15:02
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@seanpmorgan
Copy link
Member

@facaiy I clipped some of the whitespace around the text and uploaded a local file so we don't need to worry about the link. If you like the image better, should we merge it into community or is the static file in repo okay?

@facaiy
Copy link
Member Author

facaiy commented Mar 16, 2019

I prefer public url to static file in the repo, but both are fine. And I'm afraid svg format cannot play well with markdown, while png format perhaps is better for web :-)

@facaiy
Copy link
Member Author

facaiy commented Mar 16, 2019

Sean, I'd like to leave it up to you :-)

@seanpmorgan
Copy link
Member

So I think we'll meet somewhere in the middle. I do think SVG is preferred format for web, but to be fair that wasn't a true svg graphic, just an image imported into svg.

I'm uncomfortable with the URL link as it's outside of our control and could be broken without our knowledge. So PNG in repo I think is a good middle ground. I could live with the URL link, but I think it needs to be cropped anyway.

@seanpmorgan seanpmorgan merged commit d2db251 into tensorflow:master Mar 16, 2019
@facaiy facaiy deleted the DOC/add_addons_logo branch March 17, 2019 02:22
Squadrick pushed a commit to Squadrick/addons that referenced this pull request Mar 26, 2019
* DOC: use logo for SIG/addons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants