Adding badge for Sanity check #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Karmel, I cannot reproduce the failure. What image are you using? And could you print the path before opening it? |
Member
Contributor
|
@facaiy sorry I did not have cycles to look into this this week. Would you like the exact commands being run internally? |
Member
|
Amit, would you mind taking a look #68? |
Contributor
Contributor
|
You can merge this now @karmel the preview looks good. |
seanpmorgan
approved these changes
Mar 26, 2019
Member
seanpmorgan
left a comment
seanpmorgan
left a comment
There was a problem hiding this comment.
Looks great.. thank you both!
Contributor
Author
|
Awesome— thanks, Amit.
…On Tue, Mar 26, 2019 at 12:27 PM Sean Morgan ***@***.***> wrote:
Merged #98 <#98> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAowofTBOnlWL9oxTbEkZg70BKkg3LUpks5vanS2gaJpZM4b_y_p>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test itself is failing right now as per the comments in #68 , but here are the badge links for the Readme when ready.